You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/15 08:39:27 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #7719: Fix ser/deserializers of ES 7.8, search query, aggregation, order, terms
kezhenxu94 opened a new pull request #7719:
URL: https://github.com/apache/skywalking/pull/7719
### Fix <bug description or the bug issue number or bug issue link>
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
The response index template in ES 6.x, [7.0, 7.8) and [7.8,) are different and the deserializer didn't take care of it correctly, now the deserializers are selected according to ES version correctly.
The patch also fixes that the `order` in aggregation doesn't take effect.
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>. NO
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md). NO NEED. Not released yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #7719: Fix ser/deserializers of ES 6/7-7.8/7.8+, search query, aggregation, order, terms
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #7719:
URL: https://github.com/apache/skywalking/pull/7719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7719: Fix ser/deserializers of ES 7.8, search query, aggregation, order, terms
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7719:
URL: https://github.com/apache/skywalking/pull/7719#discussion_r708996783
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java
##########
@@ -73,7 +73,12 @@ protected boolean isExists(Model model) throws StorageException {
boolean exist = esClient.isExistsTemplate(tableName)
&& esClient.isExistsIndex(TimeSeriesUtils.latestWriteIndexName(model));
final Optional<IndexTemplate> template = esClient.getTemplate(tableName);
- if (exist && template.isPresent() && IndexController.INSTANCE.isMetricModel(model)) {
+
+ if ((exist && !template.isPresent()) || (!exist && template.isPresent())) {
+ throw new Error("Bug!!! ElasticSearch client query template result is not consistent");
Review comment:
```suggestion
throw new Error("[Bug warning]ElasticSearch client query template result is not consistent. Please file an issue to Apache SkyWalking.(https://github.com/apache/skywalking/issues)");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #7719: Fix ser/deserializers of ES 7.8, search query, aggregation, order, terms
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7719:
URL: https://github.com/apache/skywalking/pull/7719#issuecomment-919819793
<details>
<summary>the screenshots</summary>
<img width="1909" alt="Screen Shot 2021-09-15 at 14 10 53" src="https://user-images.githubusercontent.com/15965696/133400605-ec18ddd9-2fb9-4c25-bd50-22e8765efca4.png">
<img width="1911" alt="Screen Shot 2021-09-15 at 14 11 00" src="https://user-images.githubusercontent.com/15965696/133400618-9155d8e0-fb18-42b3-9f92-af3d6b937003.png">
<img width="1919" alt="Screen Shot 2021-09-15 at 14 11 17" src="https://user-images.githubusercontent.com/15965696/133400621-6f3ef56c-074d-43e5-a539-4bf4467b90f0.png">
<img width="1913" alt="Screen Shot 2021-09-15 at 14 11 24" src="https://user-images.githubusercontent.com/15965696/133400624-b782b465-81d1-4bbb-9df7-76296f8a01d7.png">
<img width="1905" alt="Screen Shot 2021-09-15 at 14 11 32" src="https://user-images.githubusercontent.com/15965696/133400630-bef91584-c889-4132-bd19-3cb379ba9c72.png">
<img width="1492" alt="Screen Shot 2021-09-15 at 14 11 43" src="https://user-images.githubusercontent.com/15965696/133400633-21996401-24ad-46e3-ad94-cda2dfda3d35.png">
<img width="1223" alt="Screen Shot 2021-09-15 at 14 11 50" src="https://user-images.githubusercontent.com/15965696/133400634-8ba4f28b-c414-4104-a764-dc2767f144b4.png">
<img width="1874" alt="Screen Shot 2021-09-15 at 14 12 06" src="https://user-images.githubusercontent.com/15965696/133400636-2fb844a6-2fd4-4ee3-b4bb-a1fa1956565d.png">
<img width="1367" alt="Screen Shot 2021-09-15 at 14 12 14" src="https://user-images.githubusercontent.com/15965696/133400639-6625ee9c-951c-4982-b1a0-eb3c84b40efe.png">
<img width="1361" alt="Screen Shot 2021-09-15 at 14 12 20" src="https://user-images.githubusercontent.com/15965696/133400642-63f39e06-1213-4c01-ace3-86cfc4c75923.png">
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org