[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #16555: Upgrade MKL-DNN dependency to v1.0

[GitBox <gi...@apache.org>]

rongzha1 commented on a change in pull request #16555: Upgrade MKL-DNN dependency to v1.0
URL: https://github.com/apache/incubator-mxnet/pull/16555#discussion_r339415651
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -477,8 +477,18 @@ inline void PushFComputeEx(const FComputeEx& fn,
         // copying A to B may not happen, and will corrupt A's memory.
         InvalidateOutputs(outputs, req);
       }
+      // add for mkldnn OP + no mkldnn OP
+      const auto is_mkldnn = Op::GetAttr<bool>("TIsMKLDNN");
+      if (!is_mkldnn.get(attrs.op, false)) {
+        std::vector<NDArray> inputs_fallback;
+        CreateDefaultInputs(inputs, &inputs_fallback);
+        fn(attrs, opctx, inputs_fallback, req, outputs);
+      } else {
+#endif
+        fn(attrs, opctx, inputs, req, outputs);
 
 Review comment:
   OK.  Changed in [16652](https://github.com/apache/incubator-mxnet/pull/16652)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services