You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/14 17:35:29 UTC

[GitHub] rahul003 commented on a change in pull request #7896: fix batchnorm test failure

rahul003 commented on a change in pull request #7896: fix batchnorm test failure
URL: https://github.com/apache/incubator-mxnet/pull/7896#discussion_r138961135
 
 

 ##########
 File path: tests/cpp/operator/batchnorm_test.cc
 ##########
 @@ -1364,15 +1364,15 @@ TEST(BATCH_NORM, TestChannelAxisSaveAndLoad) {
 
 /*! \brief Insert the channel field `channelCount` into the shape at `channelAxis` position */
 static TShape MakeShape(const std::vector<index_t>& shape,
-                        unsigned int channelAxis,
+                        signed int channelAxis,
 
 Review comment:
   channelAxis has been referred to as signed int at multiple places in the test. Even this line had history where it was referred to as signed int. I guess to make it explicit. So I just stuck to that style. I can change them to int if that's better.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services