You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2016/06/22 01:54:21 UTC
[1/4] incubator-kudu git commit: Make 'num_attempts' in RequestIdPB
required
Repository: incubator-kudu
Updated Branches:
refs/heads/master 0c8f72b4c -> a35d556d0
Make 'num_attempts' in RequestIdPB required
We need to differentiate between attempts, on the server, so that we
can handle dangling handlers when multiple attempts at the same RPC
are happening at the same time (e.g. a client-originated write rpc
and the same rpc originating from another replica).
Differentiating which attempt is executing on the server side
requires distinguishing between different attempts. Using 'num_attempts'
is a natural way to do so.
Change-Id: Idd8f780826438278993554546edfae90bf1a39df
Reviewed-on: http://gerrit.cloudera.org:8080/3408
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/8e7e449f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/8e7e449f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/8e7e449f
Branch: refs/heads/master
Commit: 8e7e449f48dc2c7b96b9b41282129a5751052adf
Parents: 0c8f72b
Author: David Alves <da...@cloudera.com>
Authored: Thu Jun 2 12:31:11 2016 -0700
Committer: David Ribeiro Alves <dr...@apache.org>
Committed: Tue Jun 21 02:59:27 2016 +0000
----------------------------------------------------------------------
src/kudu/rpc/rpc_header.proto | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/8e7e449f/src/kudu/rpc/rpc_header.proto
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/rpc_header.proto b/src/kudu/rpc/rpc_header.proto
index 685460e..3002a21 100644
--- a/src/kudu/rpc/rpc_header.proto
+++ b/src/kudu/rpc/rpc_header.proto
@@ -123,8 +123,9 @@ message RequestIdPB {
// Unset if there isn't an incomplete RPC.
optional int64 first_incomplete_seq_no = 3;
- // The number of times this RPC has been tried, only set after the first attempt.
- optional int32 attempt_no = 4;
+ // The number of times this RPC has been tried.
+ // Set to 1 in the first attempt.
+ required int32 attempt_no = 4;
}
// The header for the RPC request frame.
[4/4] incubator-kudu git commit: Add additional documentation for bad
installation
Posted by ad...@apache.org.
Add additional documentation for bad installation
Added more to the documentation for botched installation. Users
should uninstall the dependencies and install them again after
cleaning the project.
See:
https://github.com/anjuwong/kudu/blob/installation-doc/docs/installation.adoc#os-x
Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Reviewed-on: http://gerrit.cloudera.org:8080/3424
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/a35d556d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/a35d556d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/a35d556d
Branch: refs/heads/master
Commit: a35d556d0cab6c6520d0d08a78f103cb7d3bf0bc
Parents: 3bfe712
Author: Andrew Wong <an...@cloudera.com>
Authored: Mon Jun 20 19:15:55 2016 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Wed Jun 22 01:53:32 2016 +0000
----------------------------------------------------------------------
docs/installation.adoc | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/a35d556d/docs/installation.adoc
----------------------------------------------------------------------
diff --git a/docs/installation.adoc b/docs/installation.adoc
index e93ac6c..4c681d0 100644
--- a/docs/installation.adoc
+++ b/docs/installation.adoc
@@ -530,6 +530,24 @@ $ cd kudu
----
$ thirdparty/build-if-necessary.sh
----
+ - If different versions of the dependencies are installed and used when calling
+`thirdparty/build-if-necessary.sh`, you may get stuck with output similar to the
+following:
++
+----
+./configure: line 16299: error near unexpected token `newline'
+./configure: line 16299: ` PKG_CHECK_MODULES('
+----
++
+The thirdparty builds may be cached and may reflect the incorrect versions of the
+dependencies. Ensure that you have the correct dependencies listed in Step 1, clean
+the workspace, and then try to re-build.
++
+[source,bash]
+----
+$ git clean -fdx
+$ thirdparty/build-if-necessary.sh
+----
. Build Kudu. Choose a build directory for the intermediate output, which can be
anywhere in your filesystem except for the `kudu` directory itself.
@@ -542,6 +560,7 @@ cd build/release
make -j4
----
+====
.OSX Build Script
====
This script provides an overview of the procedure to build Kudu on OSX, and can
[2/4] incubator-kudu git commit: Allow crcutil* symbols in the client
Posted by ad...@apache.org.
Allow crcutil* symbols in the client
A previous patch moved PB tracing utilities into pb_util.cc/h but
in order to use these in the client (in RcpController, follow up patch)
the crcutil* symbols need to be allowed.
Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Reviewed-on: http://gerrit.cloudera.org:8080/3412
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/021658df
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/021658df
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/021658df
Branch: refs/heads/master
Commit: 021658dfbc30f79254271cf80d43080462e129e2
Parents: 8e7e449
Author: David Alves <da...@cloudera.com>
Authored: Mon Jun 20 11:59:02 2016 -0700
Committer: David Ribeiro Alves <dr...@apache.org>
Committed: Tue Jun 21 02:59:36 2016 +0000
----------------------------------------------------------------------
src/kudu/client/symbols.map | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/021658df/src/kudu/client/symbols.map
----------------------------------------------------------------------
diff --git a/src/kudu/client/symbols.map b/src/kudu/client/symbols.map
index 0f08921..7c6db4d 100644
--- a/src/kudu/client/symbols.map
+++ b/src/kudu/client/symbols.map
@@ -29,6 +29,10 @@
gflags_mutex_namespace::*;
glog_internal_namespace_::*;
+ # crcutil
+ crcutil::*;
+ crcutil_interface::*;
+
# devtoolset - the Red Hat devtoolset statically links c++11 symbols
# into binaries so that the result may be executed on a system with an
# older libstdc++ which doesn't include the necessary c++11 symbols.
[3/4] incubator-kudu git commit: Mark the Response accessors in
transactions/transaction's state const
Posted by ad...@apache.org.
Mark the Response accessors in transactions/transaction's state const
There is no reason why these accessors should't be const and by making
them as such we can access the response through state(), instead of
mutable_state().
Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
Reviewed-on: http://gerrit.cloudera.org:8080/3419
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/3bfe7127
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/3bfe7127
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/3bfe7127
Branch: refs/heads/master
Commit: 3bfe7127778f7a855c3599c3cf58439140edbdc9
Parents: 021658d
Author: David Alves <da...@cloudera.com>
Authored: Mon Jun 20 21:48:23 2016 -0700
Committer: David Ribeiro Alves <dr...@apache.org>
Committed: Tue Jun 21 18:17:40 2016 +0000
----------------------------------------------------------------------
src/kudu/tablet/transactions/alter_schema_transaction.h | 2 +-
src/kudu/tablet/transactions/transaction.h | 2 +-
src/kudu/tablet/transactions/write_transaction.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/3bfe7127/src/kudu/tablet/transactions/alter_schema_transaction.h
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/alter_schema_transaction.h b/src/kudu/tablet/transactions/alter_schema_transaction.h
index 744097d..cfcae3f 100644
--- a/src/kudu/tablet/transactions/alter_schema_transaction.h
+++ b/src/kudu/tablet/transactions/alter_schema_transaction.h
@@ -52,7 +52,7 @@ class AlterSchemaTransactionState : public TransactionState {
}
const tserver::AlterSchemaRequestPB* request() const OVERRIDE { return request_; }
- tserver::AlterSchemaResponsePB* response() OVERRIDE { return response_; }
+ tserver::AlterSchemaResponsePB* response() const OVERRIDE { return response_; }
void set_schema(const Schema* schema) { schema_ = schema; }
const Schema* schema() const { return schema_; }
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/3bfe7127/src/kudu/tablet/transactions/transaction.h
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/transaction.h b/src/kudu/tablet/transactions/transaction.h
index 2a10f23..0a133f5 100644
--- a/src/kudu/tablet/transactions/transaction.h
+++ b/src/kudu/tablet/transactions/transaction.h
@@ -135,7 +135,7 @@ class TransactionState {
// Returns the response PB associated with this transaction, or NULL.
// This will only return a non-null object for leader-side transactions.
- virtual google::protobuf::Message* response() { return NULL; }
+ virtual google::protobuf::Message* response() const { return NULL; }
// Sets the ConsensusRound for this transaction, if this transaction is
// being executed through the consensus system.
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/3bfe7127/src/kudu/tablet/transactions/write_transaction.h
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/write_transaction.h b/src/kudu/tablet/transactions/write_transaction.h
index 162d6b4..134c04b 100644
--- a/src/kudu/tablet/transactions/write_transaction.h
+++ b/src/kudu/tablet/transactions/write_transaction.h
@@ -94,7 +94,7 @@ class WriteTransactionState : public TransactionState {
// Returns the prepared response to the client that will be sent when this
// transaction is completed, if this transaction was started by a client.
- tserver::WriteResponsePB *response() OVERRIDE {
+ tserver::WriteResponsePB *response() const OVERRIDE {
return response_;
}