You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/10/08 07:27:18 UTC
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3466:
[Zeppelin-4341] fix role setting when using multiple realms
zjffdu commented on a change in pull request #3466: [Zeppelin-4341] fix role setting when using multiple realms
URL: https://github.com/apache/zeppelin/pull/3466#discussion_r332367273
##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/utils/SecurityUtils.java
##########
@@ -157,11 +157,15 @@ public static Collection getRealmsList() {
);
if (auth != null) {
roles = new HashSet<>(auth.getRoles());
+ break;
+ }
+ } catch (Throwable t) {
+ if (log.isDebugEnabled()) {
+ String msg = "Realm [" + realm +
+ "] threw an exception during a multi-realm authorization attempt:";
+ log.debug(msg, t);
Review comment:
Is it OK for swallow the error via `log.debug` ? Would it be better to use `log.warn` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services