You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2016/03/21 12:44:03 UTC
Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description
-------
Shutdown hook is calling for each command bean whenver we do ctrl+c.
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
src/site/apt/user/client-config.apt 714db18
Diff: https://reviews.apache.org/r/45099/diff/
Testing
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
Thanks,
Raju Bairishetti
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 12, 2016, 12:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 127
> > <https://reviews.apache.org/r/45099/diff/1/?file=1308293#file1308293line127>
> >
> > Hope this is used only in unit tests. Can we reduce the scope?
> >
> > Also, Commands should not take responsibility for closing these clients.
> >
> > what happens if we do the following :
> > qcom.setclient(client1);
> > qcom.setclient(client2);
> >
> > qcom.closeConnection() would only close client2.
> >
> > Instead we should leave closing of client1 and client2 to the creaters of them.
This setter will be invoked when cli is launched(i.e. LensConnectionCommand is called). This setter is mostly used in test cases.
I agree with your point, we can revert LENS-853. In that case, users(or tests cases) should exeplicitly close Lens clients instead of closing Lens commands.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review128377
-----------------------------------------------------------
On March 21, 2016, 11:47 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:47 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
> src/site/apt/user/client-config.apt 714db18
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review128377
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 80)
<https://reviews.apache.org/r/45099/#comment191815>
I feel ealrier code of static registraion of shutdown hook is correct - https://github.com/apache/lens/blob/apache-lens-2.5.0-beta/lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 127)
<https://reviews.apache.org/r/45099/#comment191817>
Hope this is used only in unit tests. Can we reduce the scope?
Also, Commands should not take responsibility for closing these clients.
what happens if we do the following :
qcom.setclient(client1);
qcom.setclient(client2);
qcom.closeConnection() would only close client2.
Instead we should leave closing of client1 and client2 to the creaters of them.
- Amareshwari Sriramadasu
On March 21, 2016, 11:47 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:47 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
> src/site/apt/user/client-config.apt 714db18
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review125003
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 81)
<https://reviews.apache.org/r/45099/#comment187746>
This will not work. Since each bean is a a baselenscommand itself, and each for each, registershutdown hook will be called exactly once. This boolean is redundant.
- Rajat Khandelwal
On March 21, 2016, 5:17 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 5:17 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
> src/site/apt/user/client-config.apt 714db18
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review140306
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 28, 2016, 10:59 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 10:59 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 0a37d01
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.835s]
> [INFO] Lens .............................................. SUCCESS [4.721s]
> [INFO] Lens API .......................................... SUCCESS [26.082s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.151s]
> [INFO] Lens Cube ......................................... SUCCESS [9:31.256s]
> [INFO] Lens DB storage ................................... SUCCESS [15.318s]
> [INFO] Lens Query Library ................................ SUCCESS [13.582s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.532s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.481s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.666s]
> [INFO] Lens Server ....................................... SUCCESS [13:40.026s]
> [INFO] Lens client ....................................... SUCCESS [1:31.229s]
> [INFO] Lens CLI .......................................... SUCCESS [1:17.334s]
> [INFO] Lens Examples ..................................... SUCCESS [8.929s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.888s]
> [INFO] Lens Distribution ................................. SUCCESS [11.928s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.754s]
> [INFO] Lens Regression ................................... SUCCESS [15.555s]
> [INFO] Lens UI ........................................... SUCCESS [0.997s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:26.443s
> [INFO] Finished at: Tue Jun 28 10:53:01 SGT 2016
> [INFO] Final Memory: 214M/1170M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 28, 2016, 11:03 a.m., Rajat Khandelwal wrote:
> > I don't think this issue still exists in master. LENS-1010 had fixed it. Can you check again?
>
> Raju Bairishetti wrote:
> I am using LENS-1010 for auto closing the lens clients using try-with-resources. LensClient won't be closed automatically if we do not initializes in try-with-resources.
>
> https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
>
> Rajat Khandelwal wrote:
> All right, but I'm saying that the original issue for which this jira was created no more exists. Now cli doesn't print the "unable to close" error message. And that's because there was one more change in LENS-1010: protection from multiple close. That is solving LENS-991. You might want to modify your current code and remove some of those.
>
> 1. +1 for checkstyle change
> 2. conversion to static shouldn't be required in BaseLensCommand. In fact -- no changes should be required.
> 3. All the other changes are in test classes. And they are mostly addition of try-with-resources block. So maybe those changes should go in a separate jira, a follow-up of LENS-1010.
This is basically reverting LENS-853 and putting single shutdown hook for CLI to close - which looks correct to me, instead of adding separate shutdown hook for each command.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review139758
-----------------------------------------------------------
On June 28, 2016, 10:59 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 10:59 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 0a37d01
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.835s]
> [INFO] Lens .............................................. SUCCESS [4.721s]
> [INFO] Lens API .......................................... SUCCESS [26.082s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.151s]
> [INFO] Lens Cube ......................................... SUCCESS [9:31.256s]
> [INFO] Lens DB storage ................................... SUCCESS [15.318s]
> [INFO] Lens Query Library ................................ SUCCESS [13.582s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.532s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.481s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.666s]
> [INFO] Lens Server ....................................... SUCCESS [13:40.026s]
> [INFO] Lens client ....................................... SUCCESS [1:31.229s]
> [INFO] Lens CLI .......................................... SUCCESS [1:17.334s]
> [INFO] Lens Examples ..................................... SUCCESS [8.929s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.888s]
> [INFO] Lens Distribution ................................. SUCCESS [11.928s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.754s]
> [INFO] Lens Regression ................................... SUCCESS [15.555s]
> [INFO] Lens UI ........................................... SUCCESS [0.997s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:26.443s
> [INFO] Finished at: Tue Jun 28 10:53:01 SGT 2016
> [INFO] Final Memory: 214M/1170M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 28, 2016, 4:33 p.m., Rajat Khandelwal wrote:
> > I don't think this issue still exists in master. LENS-1010 had fixed it. Can you check again?
>
> Raju Bairishetti wrote:
> I am using LENS-1010 for auto closing the lens clients using try-with-resources. LensClient won't be closed automatically if we do not initializes in try-with-resources.
>
> https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
All right, but I'm saying that the original issue for which this jira was created no more exists. Now cli doesn't print the "unable to close" error message. And that's because there was one more change in LENS-1010: protection from multiple close. That is solving LENS-991. You might want to modify your current code and remove some of those.
1. +1 for checkstyle change
2. conversion to static shouldn't be required in BaseLensCommand. In fact -- no changes should be required.
3. All the other changes are in test classes. And they are mostly addition of try-with-resources block. So maybe those changes should go in a separate jira, a follow-up of LENS-1010.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review139758
-----------------------------------------------------------
On June 28, 2016, 4:29 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 4:29 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 0a37d01
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.835s]
> [INFO] Lens .............................................. SUCCESS [4.721s]
> [INFO] Lens API .......................................... SUCCESS [26.082s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.151s]
> [INFO] Lens Cube ......................................... SUCCESS [9:31.256s]
> [INFO] Lens DB storage ................................... SUCCESS [15.318s]
> [INFO] Lens Query Library ................................ SUCCESS [13.582s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.532s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.481s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.666s]
> [INFO] Lens Server ....................................... SUCCESS [13:40.026s]
> [INFO] Lens client ....................................... SUCCESS [1:31.229s]
> [INFO] Lens CLI .......................................... SUCCESS [1:17.334s]
> [INFO] Lens Examples ..................................... SUCCESS [8.929s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.888s]
> [INFO] Lens Distribution ................................. SUCCESS [11.928s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.754s]
> [INFO] Lens Regression ................................... SUCCESS [15.555s]
> [INFO] Lens UI ........................................... SUCCESS [0.997s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:26.443s
> [INFO] Finished at: Tue Jun 28 10:53:01 SGT 2016
> [INFO] Final Memory: 214M/1170M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Raju Bairishetti <ra...@gmail.com>.
> On June 28, 2016, 11:03 a.m., Rajat Khandelwal wrote:
> > I don't think this issue still exists in master. LENS-1010 had fixed it. Can you check again?
I am using LENS-1010 for auto closing the lens clients using try-with-resources. LensClient won't be closed automatically if we do not initializes in try-with-resources.
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review139758
-----------------------------------------------------------
On June 28, 2016, 10:59 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 10:59 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 0a37d01
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.835s]
> [INFO] Lens .............................................. SUCCESS [4.721s]
> [INFO] Lens API .......................................... SUCCESS [26.082s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.151s]
> [INFO] Lens Cube ......................................... SUCCESS [9:31.256s]
> [INFO] Lens DB storage ................................... SUCCESS [15.318s]
> [INFO] Lens Query Library ................................ SUCCESS [13.582s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.532s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.481s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.666s]
> [INFO] Lens Server ....................................... SUCCESS [13:40.026s]
> [INFO] Lens client ....................................... SUCCESS [1:31.229s]
> [INFO] Lens CLI .......................................... SUCCESS [1:17.334s]
> [INFO] Lens Examples ..................................... SUCCESS [8.929s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.888s]
> [INFO] Lens Distribution ................................. SUCCESS [11.928s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.754s]
> [INFO] Lens Regression ................................... SUCCESS [15.555s]
> [INFO] Lens UI ........................................... SUCCESS [0.997s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:26.443s
> [INFO] Finished at: Tue Jun 28 10:53:01 SGT 2016
> [INFO] Final Memory: 214M/1170M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review139758
-----------------------------------------------------------
I don't think this issue still exists in master. LENS-1010 had fixed it. Can you check again?
checkstyle/src/main/resources/checkstyle.xml (line 202)
<https://reviews.apache.org/r/45099/#comment205099>
+1
- Rajat Khandelwal
On June 28, 2016, 4:29 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 4:29 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 0a37d01
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.835s]
> [INFO] Lens .............................................. SUCCESS [4.721s]
> [INFO] Lens API .......................................... SUCCESS [26.082s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.151s]
> [INFO] Lens Cube ......................................... SUCCESS [9:31.256s]
> [INFO] Lens DB storage ................................... SUCCESS [15.318s]
> [INFO] Lens Query Library ................................ SUCCESS [13.582s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:21.532s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.481s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.666s]
> [INFO] Lens Server ....................................... SUCCESS [13:40.026s]
> [INFO] Lens client ....................................... SUCCESS [1:31.229s]
> [INFO] Lens CLI .......................................... SUCCESS [1:17.334s]
> [INFO] Lens Examples ..................................... SUCCESS [8.929s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.888s]
> [INFO] Lens Distribution ................................. SUCCESS [11.928s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.754s]
> [INFO] Lens Regression ................................... SUCCESS [15.555s]
> [INFO] Lens UI ........................................... SUCCESS [0.997s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:26.443s
> [INFO] Finished at: Tue Jun 28 10:53:01 SGT 2016
> [INFO] Final Memory: 214M/1170M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
(Updated June 28, 2016, 10:59 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
updated test results sections
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description
-------
Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
Diffs
-----
checkstyle/src/main/resources/checkstyle.xml 0a37d01
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
Diff: https://reviews.apache.org/r/45099/diff/
Testing (updated)
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.835s]
[INFO] Lens .............................................. SUCCESS [4.721s]
[INFO] Lens API .......................................... SUCCESS [26.082s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.151s]
[INFO] Lens Cube ......................................... SUCCESS [9:31.256s]
[INFO] Lens DB storage ................................... SUCCESS [15.318s]
[INFO] Lens Query Library ................................ SUCCESS [13.582s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:21.532s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [30.481s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.666s]
[INFO] Lens Server ....................................... SUCCESS [13:40.026s]
[INFO] Lens client ....................................... SUCCESS [1:31.229s]
[INFO] Lens CLI .......................................... SUCCESS [1:17.334s]
[INFO] Lens Examples ..................................... SUCCESS [8.929s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.888s]
[INFO] Lens Distribution ................................. SUCCESS [11.928s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.603s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.754s]
[INFO] Lens Regression ................................... SUCCESS [15.555s]
[INFO] Lens UI ........................................... SUCCESS [0.997s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:26.443s
[INFO] Finished at: Tue Jun 28 10:53:01 SGT 2016
[INFO] Final Memory: 214M/1170M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
(Updated June 28, 2016, 10:56 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description
-------
Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
Diffs
-----
checkstyle/src/main/resources/checkstyle.xml 0a37d01
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
Diff: https://reviews.apache.org/r/45099/diff/
Testing (updated)
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
All tests are passing except TestUnionQueries from lens-cube. Jira is already present for that.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.444s]
[INFO] Lens .............................................. SUCCESS [2.541s]
[INFO] Lens API .......................................... SUCCESS [19.498s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.130s]
[INFO] Lens Cube ......................................... SUCCESS [8:07.699s]
[INFO] Lens DB storage ................................... SUCCESS [14.925s]
[INFO] Lens Query Library ................................ SUCCESS [12.489s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:13.761s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [28.063s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [12.738s]
[INFO] Lens Server ....................................... SUCCESS [15:45.092s]
[INFO] Lens client ....................................... SUCCESS [31.307s]
[INFO] Lens CLI .......................................... SUCCESS [40.512s]
[INFO] Lens Examples ..................................... SUCCESS [8.947s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.851s]
[INFO] Lens Distribution ................................. SUCCESS [8.523s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:10.915s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.558s]
[INFO] Lens Regression ................................... SUCCESS [10.022s]
[INFO] Lens UI ........................................... SUCCESS [0.344s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:46.885s
[INFO] Finished at: Mon Feb 29 08:59:11 SGT 2016
[INFO] Final Memory: 184M/1244M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
(Updated June 28, 2016, 10:49 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Revert LENS-853 and close lens client in tests using try-with-resource
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description
-------
Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 0a37d01
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 9eb73b3
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java d1ec94e
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 705aace
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 80dd0d1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
Diff: https://reviews.apache.org/r/45099/diff/
Testing
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
Thanks,
Raju Bairishetti
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 22, 2016, 2:54 a.m., Puneet Gupta wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 80
> > <https://reviews.apache.org/r/45099/diff/1/?file=1308293#file1308293line80>
> >
> > Should we move this method to LensClientSingletonWrapper ?
> >
> > We can add one more method and users can choose which one to use.
> >
> > New method : LensClientSingletonWrapper.getClient(boolean closeClientOnExit)
> >
> > Exiting method LensClientSingletonWrapper.getClient() will call
> > getClient(true) //default behaviour is close on exit
> >
> > If it makes sense we can do this as part of another JIRA, the current changes look fine for this JIRA.
I also feel that it should be in LensClientSingletonWrapper and would be clean.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review124718
-----------------------------------------------------------
On March 21, 2016, 11:47 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:47 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
> src/site/apt/user/client-config.apt 714db18
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/#review124718
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 80)
<https://reviews.apache.org/r/45099/#comment187351>
Should we move this method to LensClientSingletonWrapper ?
We can add one more method and users can choose which one to use.
New method : LensClientSingletonWrapper.getClient(boolean closeClientOnExit)
Exiting method LensClientSingletonWrapper.getClient() will call
getClient(true) //default behaviour is close on exit
If it makes sense we can do this as part of another JIRA, the current changes look fine for this JIRA.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 81)
<https://reviews.apache.org/r/45099/#comment187354>
Do u think we need to synchronoize ?
From what I know synchronization will not be required since commands can not be created parallay on cli.
- Puneet Gupta
On March 21, 2016, 11:47 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45099/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:47 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: lens-991
> https://issues.apache.org/jira/browse/lens-991
>
>
> Repository: lens
>
>
> Description
> -------
>
> Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
> src/site/apt/user/client-config.apt 714db18
>
> Diff: https://reviews.apache.org/r/45099/diff/
>
>
> Testing
> -------
>
> **Before applying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
> at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
> at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
> at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
> at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
> LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
>
> **After aplying patch:**
>
> lens-shell>show cubes
> No cube found
> lens-shell>show params
> ...
> lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 45099: LENS-991: Seeing multiple close calls and
failures of connection after LENS-853
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
(Updated March 21, 2016, 11:47 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description (updated)
-------
Shutdown hook was getting called for each lens **command bean** whenver we do ctrl+c on cli.
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java be1ca12
src/site/apt/user/client-config.apt 714db18
Diff: https://reviews.apache.org/r/45099/diff/
Testing
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException: Unable to close lens connection with params LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi', user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
Thanks,
Raju Bairishetti