You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/30 15:19:39 UTC
[GitHub] [kafka] dajac opened a new pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
dajac opened a new pull request #10443:
URL: https://github.com/apache/kafka/pull/10443
The `kafka-preferred-replica-election` command was deprecated in 2.4. As we removed the related APIs in the Admin client (https://github.com/apache/kafka/pull/10440), we can also remove the command line tool. `kafka-leader-election` can be used instead.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810349142
@ijuma What do you think about this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810928907
I have updated the upgrade notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#discussion_r604859584
##########
File path: docs/upgrade.html
##########
@@ -34,6 +34,7 @@ <h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in 3
<li>The deprecated <code>Admin.electedPreferredLeaders()</code> methods were removed. Please use <code>Admin.electLeaders</code> instead.</li>
<li>The deprecated <code>ConfigEntry</code> constructor was removed (<a href="https://issues.apache.org/jira/browse/KAFKA-12577">KAFKA-12577</a>).
Please use the remaining public constructor instead.</li>
+ <li>The deprecated <code>kafka-preferred-replica-election</code> command line tool was removed. Please use <code>kafka-leader-election</code> instead.</li>
Review comment:
I would move this just above or below the related admin API removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810730462
+1 to get rid of it. Could you update `upgrade.html` to include the replacement of `kafka-preferred-replica-election`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-811035284
Thinking about it, people would have to adjust to using the script with bootstrap-server and that was introduced much later, so I'm fine with removing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810368591
Good question. I think this script is more widely used since it has existed for a lot longer than the admin commands we have removed in #10440. One question: could the script just point to the new script? Are the commands different enough that it would not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810840614
> Good question. I think this script is more widely used since it has existed for a lot longer than the admin commands we have removed in #10440. One question: could the script just point to the new command? Are the commands different enough that it would not work?
I just checked. It would still break current usages as the new script expect `--election-type` arg which is not in the old script. So existing users would have to adapt anyway. The semantic of `--path-to-json-file` is also slightly different in the two scripts. I think that this would be even more confusing for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#discussion_r605010766
##########
File path: docs/upgrade.html
##########
@@ -34,6 +34,7 @@ <h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in 3
<li>The deprecated <code>Admin.electedPreferredLeaders()</code> methods were removed. Please use <code>Admin.electLeaders</code> instead.</li>
<li>The deprecated <code>ConfigEntry</code> constructor was removed (<a href="https://issues.apache.org/jira/browse/KAFKA-12577">KAFKA-12577</a>).
Please use the remaining public constructor instead.</li>
+ <li>The deprecated <code>kafka-preferred-replica-election</code> command line tool was removed. Please use <code>kafka-leader-election</code> instead.</li>
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma edited a comment on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810368591
Good question. I think this script is more widely used since it has existed for a lot longer than the admin commands we have removed in #10440. One question: could the script just point to the new command? Are the commands different enough that it would not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810680451
I'm somewhat more inclined to just get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10443:
URL: https://github.com/apache/kafka/pull/10443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-811333762
Failed tests are not related. Merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org