You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Erik van Oosten (JIRA)" <ji...@apache.org> on 2008/02/18 16:56:34 UTC
[jira] Created: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Autocomplete window has wrong position in scrolled context
----------------------------------------------------------
Key: WICKET-1355
URL: https://issues.apache.org/jira/browse/WICKET-1355
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.3.1
Reporter: Erik van Oosten
Fix For: 1.3.2
Attachments: wicket-autocomplete.js
When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Alex Jacoby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595021#action_12595021 ]
Alex Jacoby commented on WICKET-1355:
-------------------------------------
The fix has one other side effect in Safari when used in modal windows: the drop-down box appears after all of the content in the modal window.
I checked and this is replicable in Safari for windows as well as for OS X.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1355:
----------------------------------
Fix Version/s: (was: 1.3.6)
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635118#action_12635118 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
Okay. I'll try. I'll be a JAOO so it has to wait till Thursday though.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.3.5
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1355:
------------------------------------
Attachment: wicket-autocomplete.js
Removed the non-working attachment.
The currently attached version works on all regular browsers.
Note: we had to move the drop-down div to another location to prevent it from staying on the same location on the screen while the content is scrolled. It is now the sibling of the input element. This may cause problems in css.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Fix For: 1.3.2
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1355:
----------------------------------
Assignee: Janne Hietamäki (was: Matej Knopp)
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.3
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Daan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790103#action_12790103 ]
Daan commented on WICKET-1355:
------------------------------
I tested the latest patch in our application, which uses Wicket 1.4.1.
I see the following behavior:
On Firefox, everything seems to work correct. The autocomplete in a Modal Window is always in the right position.
On Safari, things are different. The autocomplete window shows there too far to the right and below (see attached screenshot https://issues.apache.org/jira/secure/attachment/12427914/Safari+autocomplete+in+Modal+Window.jpg)
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: Safari autocomplete in Modal Window.jpg, wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582622#action_12582622 ]
Gerolf Seitz commented on WICKET-1355:
--------------------------------------
in case we don't want to move the dropdown div to become a sibling of the textbox, the method YAHOO.Dom.getXY correctly calculates the position in a scrolled context.
and since it's BSD licensed we could also use it in wicket-autocomplete.js
needless to say that it's at least about 5 times the size (LOC) as the current getPosition method.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.3
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586448#action_12586448 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
The changes for bug [WICKET-1329] should probably be undone when the fix attached to this issue is applied.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1355:
-------------------------------------
Fix Version/s: (was: 1.3.4)
1.3.5
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.5
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1355) Autocomplete window has
wrong position in scrolled context
Posted by "Richard Wilkinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595188#action_12595188 ]
richardwilko edited comment on WICKET-1355 at 5/8/08 4:08 AM:
-------------------------------------------------------------------
I tried this on my code, but now the autocomplete div appears behind some of the content on my page (its not flash or anything, just normal html + css) On firefox . Didnt have this problem with wicket 1.3.0
was (Author: richardwilko):
I tried this on my code, but now the autocomplete div appears behind some of the content on my page (its not flash or anything, just normal html + css). Didnt have this problem with wicket 1.3.0
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Richard Wilkinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595188#action_12595188 ]
Richard Wilkinson commented on WICKET-1355:
-------------------------------------------
I tried this on my code, but now the autocomplete div appears behind some of the content on my page (its not flash or anything, just normal html + css). Didnt have this problem with wicket 1.3.0
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903873#action_12903873 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
Thanks Igor. But indeed, lets just drop it. The situation in which this happens is too specific (and hard to reproduce), and apparently hard to solve in all browsers, to warrant large changes.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: Safari autocomplete in Modal Window.jpg, wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1355:
------------------------------------
Attachment: (was: wicket-autocomplete.js)
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Fix For: 1.3.2
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636932#action_12636932 ]
Johan Compagner commented on WICKET-1355:
-----------------------------------------
already a patch underway?
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.3.5
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778918#action_12778918 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
- wicket-1355-wicket-1.4.x-autocomplete.patch
can ALSO be applied in trunk (e.g. in http://svn.apache.org/repos/asf/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete)
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778940#action_12778940 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
The fix is based on the idea that it is very hard to position a div relative to a textfield when that div is added to the document body. Instead the div will be added as a sibling of the textfield. The idea came from colleague Tim Taylor (toolman) who also gave me the initial patch.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1355:
---------------------------------------
Fix Version/s: (was: 1.3.3)
1.3.4
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1355) Autocomplete window has
wrong position in scrolled context
Posted by "Richard Wilkinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595188#action_12595188 ]
richardwilko edited comment on WICKET-1355 at 5/8/08 7:16 AM:
-------------------------------------------------------------------
I tried this on my code, but now the autocomplete div appears behind some of the content on my page (its not flash or anything, just normal html + css) On firefox . Didnt have this problem with wicket 1.3.0
Edit:
the problem seems to be how the div is added to the page. In the newer version it is like this:
wicketGet(elementId).parentNode.appendChild(choiceDiv); (line 159)
and in the older version it was like this:
document.body.appendChild(choiceDiv);
I changed it back to the old way and everything works as before.
was (Author: richardwilko):
I tried this on my code, but now the autocomplete div appears behind some of the content on my page (its not flash or anything, just normal html + css) On firefox . Didnt have this problem with wicket 1.3.0
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Alex Jacoby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594990#action_12594990 ]
Alex Jacoby commented on WICKET-1355:
-------------------------------------
The attached fix worked for me in Firefox, but not in Safari.
Same problem as described in this thread:
http://www.nabble.com/Strange-behaviour-with-autocomplete-to16489045.html
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1355:
------------------------------------
Attachment: wicket-autocomplete.js
A fix for the problem.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Fix For: 1.3.2
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1355:
---------------------------------------
Fix Version/s: (was: 1.3.2)
1.3.3
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Fix For: 1.3.3
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Daan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daan updated WICKET-1355:
-------------------------
Attachment: Safari autocomplete in Modal Window.jpg
The autocomplete list is placed too far to the right and below.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: Safari autocomplete in Modal Window.jpg, wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569925#action_12569925 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
Attached code is not yet correct.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Fix For: 1.3.2
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1355:
-------------------------------------
Assignee: Igor Vaynberg (was: Janne Hietamäki)
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.3.5
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1355:
----------------------------------
Assignee: Matej Knopp
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Matej Knopp
> Fix For: 1.3.3
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-1355:
------------------------------------
Attachment: wicket-1355-wicket-1.4.x-autocomplete.patch
wicket-1355-wicket-1.3.x-autocomplete.patch
Attached 2 patches:
- wicket-1355-wicket-1.3.x-autocomplete.patch
to be applied in http://svn.apache.org/repos/asf/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete
- wicket-1355-wicket-1.4.x-autocomplete.patch
to be applied in http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "David Leangen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586217#action_12586217 ]
David Leangen commented on WICKET-1355:
---------------------------------------
This component was not working properly for me until this fix was applied.
I haven't looked into this closely, but I can say that it works for me. Hope somebody will apply this soon to the code base. :-)
Thanks!
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1355.
-----------------------------------
Resolution: Cannot Reproduce
just tried to repro and could not. please attach a quickstart.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: Safari autocomplete in Modal Window.jpg, wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635112#action_12635112 ]
Igor Vaynberg commented on WICKET-1355:
---------------------------------------
erik, can you please attach a patch rather then the file itself, since the file has changed it makes it impossible to apply your changes.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.5
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785895#action_12785895 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
One disadvantage of positioning the div as sibling of the textfield is that the dropdown div will never be able to extend the area of the first parent with position absolute. I.e. you need to make sure that there is enough room below the textfield within the parent (make sure some more input fields follow, or just add some empty space). This will happen with modal windows, but this will not be a problem at all when you have no such parent.
This disadvantage outweights the disadvantage of having no visible dropdown div at all.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Attachments: wicket-1355-wicket-1.3.x-autocomplete.patch, wicket-1355-wicket-1.4.x-autocomplete.patch, wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1355:
-------------------------------------
Fix Version/s: (was: 1.3.5)
1.3.6
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.3.6
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1355) Autocomplete window has wrong
position in scrolled context
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595347#action_12595347 ]
Erik van Oosten commented on WICKET-1355:
-----------------------------------------
Richard, that change was the whole point of the fix. Apparently there is still a problem with the z-index, but reverting this line will not fix the problem of this issue.
> Autocomplete window has wrong position in scrolled context
> ----------------------------------------------------------
>
> Key: WICKET-1355
> URL: https://issues.apache.org/jira/browse/WICKET-1355
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.1
> Reporter: Erik van Oosten
> Assignee: Janne Hietamäki
> Fix For: 1.3.4
>
> Attachments: wicket-autocomplete.js
>
>
> When the autocompleted field is located in a scrolled div, the drop-down window is positioned too far down.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.