You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/14 18:01:39 UTC

[GitHub] DaveDeCaprio opened a new pull request #23539: [SPARK-26617][SQL] Cache manager locks

DaveDeCaprio opened a new pull request #23539: [SPARK-26617][SQL] Cache manager locks
URL: https://github.com/apache/spark/pull/23539
 
 
   ## What changes were proposed in this pull request?
   
   Fixed several places in CacheManager where a write lock was being held while running the query optimizer.  This could cause a very lock block if the query optimization takes a long time.  This builds on changes from [SPARK-26548] that fixed this issue for one specific case in the CacheManager.
   
   @gatorsmile This is very similar to the PR you approved last week.
   
   ## How was this patch tested?
   
   Has been tested on a live system where the blocking was causing major issues and it is working well.
   CacheManager has no explicit unit test but is used in many places internally as part of the SharedState.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org