You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/05/22 12:51:02 UTC
Re: Review Request 70550: Added `UPDATE_QUOTA_WITH_CONFIG`
authorization in the local authorizor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/
-----------------------------------------------------------
(Updated May 22, 2019, 5:51 a.m.)
Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, Benjamin Mahler, and Till Toenshoff.
Changes
-------
Addressed Ben's comment.
Summary (updated)
-----------------
Added `UPDATE_QUOTA_WITH_CONFIG` authorization in the local authorizor.
Bugs: MESOS-9640
https://issues.apache.org/jira/browse/MESOS-9640
Repository: mesos
Description
-------
Also added a test.
Diffs (updated)
-----
include/mesos/authorizer/acls.proto 85a3979bc02ab0145a0934f29eeef7bb65f3c42c
include/mesos/authorizer/authorizer.hpp a86a6eeb592adfc267dcf3faef40e8da3471feaf
src/authorizer/local/authorizer.cpp ec86f053357e4bc85532ea4073b57b272ffc74fe
src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee
Diff: https://reviews.apache.org/r/70550/diff/2/
Changes: https://reviews.apache.org/r/70550/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70550: Added `UPDATE_QUOTA_WITH_CONFIG`
authorization in the local authorizor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review215467
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70549, 70550]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 22, 2019, 12:51 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> -----------------------------------------------------------
>
> (Updated May 22, 2019, 12:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added a test.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto 85a3979bc02ab0145a0934f29eeef7bb65f3c42c
> include/mesos/authorizer/authorizer.hpp a86a6eeb592adfc267dcf3faef40e8da3471feaf
> src/authorizer/local/authorizer.cpp ec86f053357e4bc85532ea4073b57b272ffc74fe
> src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee
>
>
> Diff: https://reviews.apache.org/r/70550/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70550: Added `UPDATE_QUOTA_WITH_CONFIG`
authorization in the local authorizor.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review215656
-----------------------------------------------------------
Ship it!
src/tests/authorization_tests.cpp
Lines 2560-2566 (patched)
<https://reviews.apache.org/r/70550/#comment302441>
Oh, we don't need a subject?
- Benjamin Mahler
On May 22, 2019, 12:51 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> -----------------------------------------------------------
>
> (Updated May 22, 2019, 12:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, Benjamin Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added a test.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto 85a3979bc02ab0145a0934f29eeef7bb65f3c42c
> include/mesos/authorizer/authorizer.hpp a86a6eeb592adfc267dcf3faef40e8da3471feaf
> src/authorizer/local/authorizer.cpp ec86f053357e4bc85532ea4073b57b272ffc74fe
> src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee
>
>
> Diff: https://reviews.apache.org/r/70550/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>