You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Niklas Gustavsson <ni...@protocol7.com> on 2006/02/12 01:40:29 UTC
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
I don't think your missing anything. The idea was to get closer in line
to how the JDK does this.
The quote handling would with this design be done within the
implementation of the command runner (e.g. Execute), that's why the
commit message said I was coming back to that. That default
implementation would use the Ant code.
However, if you do not think this is a good idea, I'll be happy to back
it out.
/niklas
Brett Porter wrote:
> Maybe I'm missing something, but are you sure you want this?
>
> At least in plexus-utils, constructing a command line with
> cl.addArg().setLine(), cl.addArg.setValue(), etc is *much* friendlier
> than creating a string array.
>
> Also, the quote handling is one of the most key things to this library.
> Are you sure it will get back to the well tested state that Ant had this
> code in? It's really the only problem I have with the plexus-utils
> version of the library.
>
> - Brett
>
> ngn@apache.org wrote:
>> Author: ngn
>> Date: Sat Feb 11 16:14:47 2006
>> New Revision: 377094
>>
>> URL: http://svn.apache.org/viewcvs?rev=377094&view=rev
>> Log:
>> Replacing the CommandLine class with String[] to work more like the JDK classes. Note that for now this also removes the special handling of quotes. Get back to this later.
>>
--
-------
Niklas Gustavsson
http://www.protocol7.com
mailto:niklas@protocol7.com
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Posted by Niklas Gustavsson <ni...@protocol7.com>.
Sorry, my bad. With a newborn around I've lost track of most of my life :-)
I will try to put some time into this project ASAP.
/niklas
Brett Porter wrote:
> Sorry, lost track of this thread. Where did we get to here?
>
> - Brett
>
> Brett Porter wrote:
>> StringBuffer is kind of like it, but don't take that too literally.
>> Please reuse the code from plexus-utils if you can! It would make
>> porting *much* easier.
>>
>> - Brett
>>
>> Niklas Gustavsson wrote:
>>> Let me rethink this a little bit. For now I'll revert the changes and
>>> work on a simpler CommandLine implementation, something in line with
>>> StringBuffer.
>>>
>>> Thanks for the feedback! :-)
>>>
>>> /niklas
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Posted by Niklas Gustavsson <ni...@protocol7.com>.
Sorry, my bad. With a newborn around I've lost track of most of my life :-)
I will try to put some time into this project ASAP.
/niklas
Brett Porter wrote:
> Sorry, lost track of this thread. Where did we get to here?
>
> - Brett
>
> Brett Porter wrote:
>> StringBuffer is kind of like it, but don't take that too literally.
>> Please reuse the code from plexus-utils if you can! It would make
>> porting *much* easier.
>>
>> - Brett
>>
>> Niklas Gustavsson wrote:
>>> Let me rethink this a little bit. For now I'll revert the changes and
>>> work on a simpler CommandLine implementation, something in line with
>>> StringBuffer.
>>>
>>> Thanks for the feedback! :-)
>>>
>>> /niklas
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Posted by Brett Porter <br...@apache.org>.
Sorry, lost track of this thread. Where did we get to here?
- Brett
Brett Porter wrote:
> StringBuffer is kind of like it, but don't take that too literally.
> Please reuse the code from plexus-utils if you can! It would make
> porting *much* easier.
>
> - Brett
>
> Niklas Gustavsson wrote:
>> Let me rethink this a little bit. For now I'll revert the changes and
>> work on a simpler CommandLine implementation, something in line with
>> StringBuffer.
>>
>> Thanks for the feedback! :-)
>>
>> /niklas
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Posted by Brett Porter <br...@apache.org>.
StringBuffer is kind of like it, but don't take that too literally.
Please reuse the code from plexus-utils if you can! It would make
porting *much* easier.
- Brett
Niklas Gustavsson wrote:
> Let me rethink this a little bit. For now I'll revert the changes and
> work on a simpler CommandLine implementation, something in line with
> StringBuffer.
>
> Thanks for the feedback! :-)
>
> /niklas
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Posted by Niklas Gustavsson <ni...@protocol7.com>.
Let me rethink this a little bit. For now I'll revert the changes and
work on a simpler CommandLine implementation, something in line with
StringBuffer.
Thanks for the feedback! :-)
/niklas
Brett Porter wrote:
> This sounds fine. I have to admit I still haven't gotten my head around
> the current state of things as much as I'd like.
>
> Will it still be possible to construct a command line in the way I've
> illustrated?
>
> If not, is it possible this class could take both types of arguments?
>
> - Brett
>
> Niklas Gustavsson wrote:
>> I don't think your missing anything. The idea was to get closer in line
>> to how the JDK does this.
>>
>> The quote handling would with this design be done within the
>> implementation of the command runner (e.g. Execute), that's why the
>> commit message said I was coming back to that. That default
>> implementation would use the Ant code.
>>
>> However, if you do not think this is a good idea, I'll be happy to back
>> it out.
>>
>> /niklas
>>
>>
>> Brett Porter wrote:
>>> Maybe I'm missing something, but are you sure you want this?
>>>
>>> At least in plexus-utils, constructing a command line with
>>> cl.addArg().setLine(), cl.addArg.setValue(), etc is *much* friendlier
>>> than creating a string array.
>>>
>>> Also, the quote handling is one of the most key things to this library.
>>> Are you sure it will get back to the well tested state that Ant had this
>>> code in? It's really the only problem I have with the plexus-utils
>>> version of the library.
>>>
>>> - Brett
>>>
>>> ngn@apache.org wrote:
>>>> Author: ngn
>>>> Date: Sat Feb 11 16:14:47 2006
>>>> New Revision: 377094
>>>>
>>>> URL: http://svn.apache.org/viewcvs?rev=377094&view=rev
>>>> Log:
>>>> Replacing the CommandLine class with String[] to work more like the
>>>> JDK classes. Note that for now this also removes the special handling
>>>> of quotes. Get back to this later.
>>>>
>>
--
-------
Niklas Gustavsson
http://www.protocol7.com
mailto:niklas@protocol7.com
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r377094 - in /jakarta/commons/sandbox/exec/trunk/src:
main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/environment/
main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Posted by Brett Porter <br...@apache.org>.
This sounds fine. I have to admit I still haven't gotten my head around
the current state of things as much as I'd like.
Will it still be possible to construct a command line in the way I've
illustrated?
If not, is it possible this class could take both types of arguments?
- Brett
Niklas Gustavsson wrote:
> I don't think your missing anything. The idea was to get closer in line
> to how the JDK does this.
>
> The quote handling would with this design be done within the
> implementation of the command runner (e.g. Execute), that's why the
> commit message said I was coming back to that. That default
> implementation would use the Ant code.
>
> However, if you do not think this is a good idea, I'll be happy to back
> it out.
>
> /niklas
>
>
> Brett Porter wrote:
>> Maybe I'm missing something, but are you sure you want this?
>>
>> At least in plexus-utils, constructing a command line with
>> cl.addArg().setLine(), cl.addArg.setValue(), etc is *much* friendlier
>> than creating a string array.
>>
>> Also, the quote handling is one of the most key things to this library.
>> Are you sure it will get back to the well tested state that Ant had this
>> code in? It's really the only problem I have with the plexus-utils
>> version of the library.
>>
>> - Brett
>>
>> ngn@apache.org wrote:
>>> Author: ngn
>>> Date: Sat Feb 11 16:14:47 2006
>>> New Revision: 377094
>>>
>>> URL: http://svn.apache.org/viewcvs?rev=377094&view=rev
>>> Log:
>>> Replacing the CommandLine class with String[] to work more like the
>>> JDK classes. Note that for now this also removes the special handling
>>> of quotes. Get back to this later.
>>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org