[jira] [Commented] (KAFKA-3312) Add a offsets methods to ZkUtils and replace relevant usages

["Vahid Hashemian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180394#comment-15180394 ] 

Vahid Hashemian commented on KAFKA-3312:
----------------------------------------

[~granthenke] Just to clarify, do you mean have some helper function in ZkUtils to build paths out of zookeeper node names? Thanks.

> Add a offsets methods to ZkUtils and replace relevant usages
> ------------------------------------------------------------
>
>                 Key: KAFKA-3312
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3312
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.1
>            Reporter: Grant Henke
>            Assignee: Vahid Hashemian
>
> There are many places in the code that manually build a zookeeper path and get or update offsets. Moving this logic to a common location in ZkUtils would be nice. 
> Ex:
> {code}
> zkUtils.readDataMaybeNull(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}")._1
> {code}
> {code}
>  zkUtils.readData(topicDirs.consumerOffsetDir + "/" + topicAndPartition.partition)._1.toLong
> {code}
> {code}
> zkUtils.updatePersistentPath(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}", partitionData.offset.toString)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)