You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Julian Reschke <ju...@greenbytes.de> on 2016/09/20 12:19:56 UTC
Re: svn commit: r1761467 - /jackrabbit/oak/trunk/oak-parent/pom.xml
On 2016-09-19 17:34, mduerig@apache.org wrote:
> Author: mduerig
> Date: Mon Sep 19 15:34:25 2016
> New Revision: 1761467
>
> URL: http://svn.apache.org/viewvc?rev=1761467&view=rev
> Log:
> OAK-4823: Upgrade Oak Segment Tar dependency to 0.0.12
> Bumping dependency to 0.0.12
>
> Modified:
> jackrabbit/oak/trunk/oak-parent/pom.xml
>
> Modified: jackrabbit/oak/trunk/oak-parent/pom.xml
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-parent/pom.xml?rev=1761467&r1=1761466&r2=1761467&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-parent/pom.xml (original)
> +++ jackrabbit/oak/trunk/oak-parent/pom.xml Mon Sep 19 15:34:25 2016
> @@ -74,7 +74,7 @@
> <!-- whether skip the surefire unit testing during the integration testing.
> Override with -Dsurefire.skip.ut=true when needed -->
> <surefire.skip.ut>false</surefire.skip.ut>
> - <segment.tar.version>0.0.10</segment.tar.version>
> + <segment.tar.version>0.0.12</segment.tar.version>
> </properties>
>
> <issueManagement>
This leads to test regressions on Windows in oak-upgrade, as,
apparently, not all files are closed as they used to.
I will revert this change to unblock my own testing (and mention it on
JIRA once it's up again).
Best regards, Julian
Re: svn commit: r1761467 - /jackrabbit/oak/trunk/oak-parent/pom.xml
Posted by Julian Reschke <ju...@gmx.de>.
On 2016-09-21 10:30, Tomek Rekawek wrote:
> Hi,
>
> FWIW, I merged OAK-4831, so now the upgrade tests won\u2019t break even if they can\u2019t cleanup the repository directory at the end. The directories are now created under ./target (so it\u2019s easy to remove them manually) and the logs will contain exact reason of the failure (in this case the dataXXX.tar file is being used by another process).
>
> So, the segment-tar can be safely updated to 0.0.12. Of course the reason why the new version doesn\u2019t release the file handle on Windows is still worth investigating.
>
> Regards,
> Tomek
Well, probably it doesn't release the file handle on other systems,
either. It's just that Windows then won't delete the file.
This sounds like a significant problem to me; does it have a JIRA issue yet?
Re: svn commit: r1761467 - /jackrabbit/oak/trunk/oak-parent/pom.xml
Posted by Tomek Rekawek <re...@adobe.com>.
Hi,
FWIW, I merged OAK-4831, so now the upgrade tests won’t break even if they can’t cleanup the repository directory at the end. The directories are now created under ./target (so it’s easy to remove them manually) and the logs will contain exact reason of the failure (in this case the dataXXX.tar file is being used by another process).
So, the segment-tar can be safely updated to 0.0.12. Of course the reason why the new version doesn’t release the file handle on Windows is still worth investigating.
Regards,
Tomek
--
Tomek Rękawek | Adobe Research | www.adobe.com
rekawek@adobe.com
> On 20 Sep 2016, at 14:26, Julian Reschke <ju...@gmx.de> wrote:
>
> On 2016-09-20 14:19, Julian Reschke wrote:
>> On 2016-09-19 17:34, mduerig@apache.org wrote:
>>> Author: mduerig
>>> Date: Mon Sep 19 15:34:25 2016
>>> New Revision: 1761467
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1761467&view=rev
>>> Log:
>>> OAK-4823: Upgrade Oak Segment Tar dependency to 0.0.12
>>> Bumping dependency to 0.0.12
>>>
>>> Modified:
>>> jackrabbit/oak/trunk/oak-parent/pom.xml
>>>
>>> Modified: jackrabbit/oak/trunk/oak-parent/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-parent/pom.xml?rev=1761467&r1=1761466&r2=1761467&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- jackrabbit/oak/trunk/oak-parent/pom.xml (original)
>>> +++ jackrabbit/oak/trunk/oak-parent/pom.xml Mon Sep 19 15:34:25 2016
>>> @@ -74,7 +74,7 @@
>>> <!-- whether skip the surefire unit testing during the integration
>>> testing.
>>> Override with -Dsurefire.skip.ut=true when needed -->
>>> <surefire.skip.ut>false</surefire.skip.ut>
>>> - <segment.tar.version>0.0.10</segment.tar.version>
>>> + <segment.tar.version>0.0.12</segment.tar.version>
>>> </properties>
>>>
>>> <issueManagement>
>>
>>
>> This leads to test regressions on Windows in oak-upgrade, as,
>> apparently, not all files are closed as they used to.
>>
>> I will revert this change to unblock my own testing (and mention it on
>> JIRA once it's up again).
>>
>> Best regards, Julian
>
>
> FWIW; the stack trace is:
>
> validateMigration(org.apache.jackrabbit.oak.upgrade.cli.SegmentToSegmentTarTest) Time elapsed: 1.3 sec <<< ERROR!
> java.io.IOException: Unable to delete file: C:\tmp\1474374318672-1\segmentstore\data00000a.tar
> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2270)
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
> at org.apache.jackrabbit.oak.upgrade.cli.container.SegmentTarNodeStoreContainer.clean(SegmentTarNodeStoreContainer.java:79)
> at org.apache.jackrabbit.oak.upgrade.cli.AbstractOak2OakTest.clean(AbstractOak2OakTest.java:130)
> at sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source)
>
>
>
Re: svn commit: r1761467 - /jackrabbit/oak/trunk/oak-parent/pom.xml
Posted by Michael Dürig <md...@apache.org>.
On 20.9.16 2:26 , Julian Reschke wrote:
> This leads to test regressions on Windows in oak-upgrade, as,
> apparently, not all files are closed as they used to.
Which emphasises the importance of having CI on Windows. See
https://issues.apache.org/jira/browse/OAK-4456. However this is blocked
on https://issues.apache.org/jira/browse/INFRA-12076 since a while now.
I think we need to start looking into external CI options to get this
moving.
Michael
Re: svn commit: r1761467 - /jackrabbit/oak/trunk/oak-parent/pom.xml
Posted by Julian Reschke <ju...@gmx.de>.
On 2016-09-20 14:19, Julian Reschke wrote:
> On 2016-09-19 17:34, mduerig@apache.org wrote:
>> Author: mduerig
>> Date: Mon Sep 19 15:34:25 2016
>> New Revision: 1761467
>>
>> URL: http://svn.apache.org/viewvc?rev=1761467&view=rev
>> Log:
>> OAK-4823: Upgrade Oak Segment Tar dependency to 0.0.12
>> Bumping dependency to 0.0.12
>>
>> Modified:
>> jackrabbit/oak/trunk/oak-parent/pom.xml
>>
>> Modified: jackrabbit/oak/trunk/oak-parent/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-parent/pom.xml?rev=1761467&r1=1761466&r2=1761467&view=diff
>>
>> ==============================================================================
>>
>> --- jackrabbit/oak/trunk/oak-parent/pom.xml (original)
>> +++ jackrabbit/oak/trunk/oak-parent/pom.xml Mon Sep 19 15:34:25 2016
>> @@ -74,7 +74,7 @@
>> <!-- whether skip the surefire unit testing during the integration
>> testing.
>> Override with -Dsurefire.skip.ut=true when needed -->
>> <surefire.skip.ut>false</surefire.skip.ut>
>> - <segment.tar.version>0.0.10</segment.tar.version>
>> + <segment.tar.version>0.0.12</segment.tar.version>
>> </properties>
>>
>> <issueManagement>
>
>
> This leads to test regressions on Windows in oak-upgrade, as,
> apparently, not all files are closed as they used to.
>
> I will revert this change to unblock my own testing (and mention it on
> JIRA once it's up again).
>
> Best regards, Julian
FWIW; the stack trace is:
validateMigration(org.apache.jackrabbit.oak.upgrade.cli.SegmentToSegmentTarTest)
Time elapsed: 1.3 sec <<< ERROR!
java.io.IOException: Unable to delete file:
C:\tmp\1474374318672-1\segmentstore\data00000a.tar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
at
org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at
org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2270)
at
org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at
org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
at
org.apache.jackrabbit.oak.upgrade.cli.container.SegmentTarNodeStoreContainer.clean(SegmentTarNodeStoreContainer.java:79)
at
org.apache.jackrabbit.oak.upgrade.cli.AbstractOak2OakTest.clean(AbstractOak2OakTest.java:130)
at sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source)