You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2013/02/07 06:34:11 UTC
[Apache Bloodhound] #376: Move upload form in plugin admin panel to
the top
#376: Move upload form in plugin admin panel to the top
------------------------+------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: major | Component: ui design
Version: | Resolution:
------------------------+------------------------
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by rjollos):
(In [1444869])
Refs #376: Moved ''Add plugin'' form to the top of the page. Use
`widget_alert.html` to render the warning.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Changes (by rjollos):
* status: new => accepted
* owner: nobody => rjollos
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by olemis):
Replying to [comment:4 rjollos]:
> [trac 11164] is where the change was made in Trac.
I c ...
> I noticed we have some inconsistencies in Bloodhound at the moment.
That's what they lookd like atm ... once upon a time
;)
> The Admin Components and other panels have the "old style" layout with
the ''Add'' forms on the right.
Please change it and move to the top .
> The Admin Milestones panel has the vertical layout with the ''Manage
Milestone'' table above the ''Add Milestone'' form.
>
Yes , because space was limited since the beginning . That's why it used
that layout in first place . The same is proposed in #248
> Here are some screen captures of changes to the Admin Plugins panel.
>
[...]
My feedback below
> [attachment:ManagePluginNormal.png]
>
`.icon-file` element is not consistent with the usage in other contexts ,
so IMO should be removed . OTOH `icon-upload` is actually right and afaicr
even included in the initial solution ... but it was removed when the
corresponding patch was committed . In general , except in a few notable
exceptions (e.g. when iconifying ticket scroll spy elements in response to
screen size limitations) , all icons I've been including in buttons have
been dropped .
>
> [attachment:ManagePluginsInsufficientPermissions.png]
Firstly remove `.well` panel and only render the `.alert` on error .
Secondly there is a template named `widget_alert.html` , please use it as
it is aimed at controlling in a single place the changes in alerts look
and feel (i.e. updates in the template will propagate right away to all
other instances) .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by matevzb):
Replying to [comment:8 olemis]:
> Replying to [comment:7 matevzb]:
> > Replying to [comment:4 rjollos]:
> > > [trac 11164] is where the change was made in Trac. I noticed we have
some inconsistencies in Bloodhound at the moment. The Admin Components and
other panels have the "old style" layout with the ''Add'' forms on the
right. The Admin Milestones panel has the vertical layout with the
''Manage Milestone'' table above the ''Add Milestone'' form.
> > >
> > The right side "Add" forms don't play nicely with responsive layout
either. I made some adjustments for the Milestones component in r1443489
(for #217), please check whether those make sense (the "Add" form was
moved to the bottom, and its width expanded to match the "Modify" form).
>
> IMO it's better to locate it at the top
Thanks, fixed in r1444566.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Changes (by rjollos):
* milestone: => Release 5
Comment:
Replying to [comment:15 olemis]:
> [...]
> PS: ... u know what I mean : add notice label
I intentionally left out that `hint` after evaluating its appearance. It
does appear that it would be technically consistent to add the `hint`, but
the `hint` is so simple that it won't be useful to most people, and I
didn't like how it stood out relative to the other actionable elements. It
emphasizes some text that won't be important for most people, and the
`hint` looks awkward next to the `submit` button.
[[Image(HintOnManagePlugins.png)]]
I looked at moving the ''Install'' button to the lower left of the form,
to be more consistent with the other forms on the Administration panels.
It looks better when leaving the `hint` in place, but overall I think the
layout looks a bit odd.
Of course, as mentioned, this may all be suplanted by the drag and drop
upload in the future, so it's probably not worth the amount of thought
I've given it already ...
[[Image(InstallButtonInLowerLeft.png)]]
... therefore I'll close this ticket for now, and suggest we revisit all
of the fine-grained details like this after we make the first cut at
getting all of the templates looking half-decent and fully-functional.
See also: comment:7:ticket:381.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by olemis):
Replying to [comment:4 rjollos]:
>
[...]
>
> Here are some screen captures of changes to the Admin Plugins panel.
Something needs to be done for the file input element.
IMO in there we should have something similar to #195 . I say similar
because the file list et al. is not needed in this case . So I'm talking
of DnD support and in-place file submission which is nice to have .
However IMO @jdreimann has the last word on this subject , or at least it
would be nice to know his opinion .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: review
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Changes (by rjollos):
* owner: rjollos => olemis
* status: accepted => review
Comment:
Replying to [comment:6 olemis]:
> > The Admin Components and other panels have the "old style" layout with
the ''Add'' forms on the right.
>
> Please change it and move to the top .
The changes will be made in #381, and I'll assign the ticket to your for
review after I've made the changes.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by olemis):
Replying to [comment:7 matevzb]:
> Replying to [comment:4 rjollos]:
> > [trac 11164] is where the change was made in Trac. I noticed we have
some inconsistencies in Bloodhound at the moment. The Admin Components and
other panels have the "old style" layout with the ''Add'' forms on the
right. The Admin Milestones panel has the vertical layout with the
''Manage Milestone'' table above the ''Add Milestone'' form.
> >
> The right side "Add" forms don't play nicely with responsive layout
either. I made some adjustments for the Milestones component in r1443489
(for #217), please check whether those make sense (the "Add" form was
moved to the bottom, and its width expanded to match the "Modify" form).
IMO it's better to locate it at the top
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: review
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by olemis):
Replying to [comment:13 rjollos]:
> Replying to [comment:6 olemis]:
>
[...]
>
> I'm reassigning the ticket to you. Please close if you find all of the
changes satisfactory.
Just this little change
{{{
#!div
{{{
#!span class="label label-info"
Notice
}}}
Upload a plugin packaged as Python egg.
}}}
PS: ... u know what I mean : add notice label
;)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by rjollos):
Replying to [comment:7 matevzb]:
> The right side "Add" forms don't play nicely with responsive layout
either. I made some adjustments for the Milestones component in r1443489
(for #217), please check whether those make sense (the "Add" form was
moved to the bottom, and its width expanded to match the "Modify" form).
I think it looks good after incorporating Olemis' suggestion. We'll get
the rest of the admin panels modified to have horizontal forms and
hopefully that will help with the responsive layout as well.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by matevzb):
Replying to [comment:4 rjollos]:
> [trac 11164] is where the change was made in Trac. I noticed we have
some inconsistencies in Bloodhound at the moment. The Admin Components and
other panels have the "old style" layout with the ''Add'' forms on the
right. The Admin Milestones panel has the vertical layout with the
''Manage Milestone'' table above the ''Add Milestone'' form.
>
The right side "Add" forms don't play nicely with responsive layout
either. I made some adjustments for the Milestones component in r1443489
(for #217), please check whether those make sense (the "Add" form was
moved to the bottom, and its width expanded to match the "Modify" form).
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Changes (by olemis):
* owner: olemis => rjollos
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:16>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by jdreimann):
Replying to [comment:5 olemis]:
> IMO in there we should have something similar to #195 . I say similar
because the file list et al. is not needed in this case . So I'm talking
of DnD support and in-place file submission which is nice to have .
>
> However IMO @jdreimann has the last word on this subject , or at least
it would be nice to know his opinion .
I'm in favour of all those admin third column actions to move to the
middle column. As for the file upload itself, yes something like #195
would be good just for consistency reasons.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by rjollos):
Replying to [comment:6 olemis]:
> > The Admin Components and other panels have the "old style" layout with
the ''Add'' forms on the right.
Okay, but I'll do that work in another ticket.
> `.icon-file` element is not consistent with the usage in other contexts
, so IMO should be removed . OTOH `icon-upload` is actually right and
afaicr even included in the initial solution ... but it was removed when
the corresponding patch was committed . In general , except in a few
notable exceptions (e.g. when iconifying ticket scroll spy elements in
response to screen size limitations) , all icons I've been including in
buttons have been dropped .
I've removed both uses of icons. I'd like to make use of them, but I'll
save changes like that for another ticket when they can be discussed in
detail.
> Firstly remove `.well` panel and only render the `.alert` on error .
>
> Secondly there is a template named `widget_alert.html` , please use it
as it is aimed at controlling in a single place the changes in alerts look
and feel (i.e. updates in the template will propagate right away to all
other instances) .
I've made both of those changes in r1444869. I'm reassigning the ticket to
you. Please close if you find all of the changes satisfactory.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Changes (by olemis):
* keywords: => admin plugins
Old description:
New description:
This is the way it looks like in Trac
[[Image(trac_x_106_upload_plugin_top.png)]]
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by rjollos):
[trac ] is where the change was made in Trac. I noticed we have some
inconsistencies in Bloodhound at the moment. The Admin Components and
other panels have the "old style" layout with the ''Add'' forms on the
right. The Admin Milestones panel has the vertical layout with the
''Manage Milestone'' table above the ''Add Milestone'' form.
Here are some changes to the Admin Plugins panel. Something needs to be
done for the file input element. I'm looking at some of the solutions in
SO:11235206.
[[Image(ManagePluginNormal.png)]]
----
[[Image(ManagePluginsInsufficientPermissions.png)]]
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: closed
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: fixed | Keywords: admin plugins
--------------------------+---------------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:18>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #376: Move upload form in plugin admin
panel to the top
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#376: Move upload form in plugin admin panel to the top
--------------------------+---------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: admin plugins
--------------------------+---------------------------
Comment (by rjollos):
Yeah, I think this is a good idea. The page layout is better on smaller
screens with 2 columns instead of 3, and the plugin upload form occupies a
small amount of space relative to the plugins, so it doesn't make sense to
have it occupy so much of the screen width.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/376#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker