You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/11/17 05:37:50 UTC
[GitHub] [plc4x] glcj opened a new pull request #287: S7szl
glcj opened a new pull request #287:
URL: https://github.com/apache/plc4x/pull/287
Add the possibility of:
1. Subscribe to Alarm8.
2. Recognition of events.
3. Alarm text processing.
4. Subscription to cyclical values.
5. Diagnostic Record Readings (SZL).
6. Proposal for documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #287: S7szl
Posted by GitBox <gi...@apache.org>.
sruehl commented on pull request #287:
URL: https://github.com/apache/plc4x/pull/287#issuecomment-986935364
no I tried the rebase locally and noticed that it might be easier to rebase the changes onto current develop. Due to timeconstraints I couldn't finish it in time. I try to finish it this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #287: S7szl
Posted by GitBox <gi...@apache.org>.
sruehl commented on pull request #287:
URL: https://github.com/apache/plc4x/pull/287#issuecomment-986019946
I try to resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] glcj commented on pull request #287: S7szl
Posted by GitBox <gi...@apache.org>.
glcj commented on pull request #287:
URL: https://github.com/apache/plc4x/pull/287#issuecomment-986927058
Hello,
I do not see the changes in the development branch, is this PR for revision?
Grateful for your time,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #287: S7szl
Posted by GitBox <gi...@apache.org>.
sruehl commented on pull request #287:
URL: https://github.com/apache/plc4x/pull/287#issuecomment-986024911
ok might be easier to rebase this... Merge was bit hard an I aborted it due to time constraints...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #287: S7szl
Posted by GitBox <gi...@apache.org>.
sruehl commented on pull request #287:
URL: https://github.com/apache/plc4x/pull/287#issuecomment-1084392309
@glcj I propose to close this PR and you reopen a new one based on a branch in this repo (feature/s7_subscription. There you need to apply your changes manually and we try then to get them merged ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #287: S7szl
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #287:
URL: https://github.com/apache/plc4x/pull/287#issuecomment-986018818
LGTM ... only thing I didn't quite understand is why a subscription field has multiple fields inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org