You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/17 22:25:41 UTC
Re: Review Request 67190: Overloaded `stringify` for `Error`s to
reduce overheads.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67190/
-----------------------------------------------------------
(Updated May 17, 2018, 10:25 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.
Changes
-------
Made the overload specific to `Error`s.
Summary (updated)
-----------------
Overloaded `stringify` for `Error`s to reduce overheads.
Repository: mesos
Description (updated)
-------
Overloaded `stringify` for `Error`s to reduce overheads.
Diffs (updated)
-----
3rdparty/stout/include/stout/stringify.hpp 49bf684a2aa18bdd9ab866eb76de5b938a3f3a4b
Diff: https://reviews.apache.org/r/67190/diff/2/
Changes: https://reviews.apache.org/r/67190/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67190: Overloaded `stringify` for `Error`s to
reduce overheads.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67190/#review203387
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67164', '67190']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67190
Relevant logs:
- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67190/logs/stout-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(640): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(773): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(798): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(808): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1092): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1092): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1353): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1353): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1426): warning C4267: 'argument': conversion from 'size_t' to 'const int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1448): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1535): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1548): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\raw_logging.cc(153): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\utilities.cc(82): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\vlog_is_on.cc(163): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\vlog_is_on.cc(163): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.14.26428\include\xutility(2483): warning C4996: 'std::copy::_Unchecked_iterators::_Deprecate': Call to 'std::copy' with parameters that may be unsafe - this call relies on the caller to check that the passed values are correct. To disable this warning, use -D_SCL_SECURE_NO_WARNINGS. See documentation on how to use Visual C++ 'Checked Iterators' [D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\base64_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\interval_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\path_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
39 Warning(s)
3 Error(s)
Time Elapsed 00:04:16.46
```
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67190/logs/libprocess-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\buffer.c(3099): warning C4244: 'function': conversion from 'int64_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499): warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(755): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(763): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evdns.c(3792): warning C4996: 'GetVersion': was declared deprecated [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\metrics_tests.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
112 Warning(s)
1 Error(s)
Time Elapsed 00:05:38.62
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67190/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (13) ->
"D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj" (default target) (32) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found [D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\tests\test-helper.vcxproj" (default target) (18) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found (compiling source file D:\DCOS\mesos\mesos\src\tests\flags.cpp) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\windows\error.hpp(101): error C3861: 'stringify': identifier not found (compiling source file D:\DCOS\mesos\mesos\src\tests\resources_utils.cpp) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
172 Warning(s)
3 Error(s)
Time Elapsed 00:19:12.02
```
- Mesos Reviewbot Windows
On May 17, 2018, 10:25 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67190/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 10:25 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.
>
>
> Bugs: MESOS-8925
> https://issues.apache.org/jira/browse/MESOS-8925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Overloaded `stringify` for `Error`s to reduce overheads.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/stringify.hpp 49bf684a2aa18bdd9ab866eb76de5b938a3f3a4b
>
>
> Diff: https://reviews.apache.org/r/67190/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>