[jira] [Commented] (METRON-1137) Build RPM for Metron MaaS as a part of rpm-docker packaging

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145187#comment-16145187 ] 

ASF GitHub Bot commented on METRON-1137:
----------------------------------------

GitHub user anandsubbu opened a pull request:

    https://github.com/apache/metron/pull/719

    METRON-1137: Build RPM for Metron MaaS as a part of rpm-docker packaging

    ## Contributor Comments
    Fixed metron.spec and the pom.xml to now copy and generate metron-maas-service RPM.
    
    **Testing Steps**
    1. Go to folder `metron-deployment/packaging/docker/rpm-docker`
    2. Run `mvn clean package -Pbuild-rpms`
    3. Once the command completes, go to `metron-deployment/packaging/docker/rpm-docker/RPMS/noarch` and the metron-maas-service RPM should be present.
    
    **Testing Done**
    - Verified testing steps above are working fine.
    - Copied metron-maas-service RPM on an openstack cluster and validated that install is going through fine.
    - Validated installed RPM contents as follows:
    ```
    [root@metron-12 ~]# rpm -ql metron-maas-0.4.1-201708290906
    /usr/metron
    /usr/metron/0.4.1
    /usr/metron/0.4.1/bin
    /usr/metron/0.4.1/bin/maas_deploy.sh
    /usr/metron/0.4.1/bin/maas_service.sh
    /usr/metron/0.4.1/lib/metron-maas-service-0.4.1-uber.jar
    ```
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [NA] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anandsubbu/incubator-metron METRON-1137

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #719
    
----
commit b0a03fba303decbae1ab818c58e9eec02919ee4a
Author: Anand Subramanian <as...@hortonworks.com>
Date:   2017-08-29T12:01:35Z

    Build metron-maas-service RPM

----


> Build RPM for Metron MaaS as a part of rpm-docker packaging
> -----------------------------------------------------------
>
>                 Key: METRON-1137
>                 URL: https://issues.apache.org/jira/browse/METRON-1137
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Anand Subramanian
>            Assignee: Anand Subramanian
>
> The metron [rpm-docker|https://github.com/apache/metron/tree/master/metron-deployment/packaging/docker/rpm-docker] needs to build metron-maas-service RPM along with the rest of the existing services.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)