You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/23 03:55:58 UTC
Review Request 21825: Added tabs for active and completed tasks in Job page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
-------
Moved task tables into active and completed tabs on job page.
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.
Diffs
-----
3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b186ae2322b45f16eddb762501b074a6dbeb6b11
Diff: https://reviews.apache.org/r/21825/diff/
Testing
-------
./gradlew run && ./gradlew build
File Attachments
----------------
active tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
completed tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43850
-----------------------------------------------------------
File Attachment: completed tasks tab - Screen Shot 2014-05-22 at 6.20.32 PM.png
<https://reviews.apache.org//r/21825/#fcomment20>
More consistent to give the table on completed tasks the same padding and whitespace as the table on active tasks. Would also solve this problem of having a double border.
- David McLaughlin
On May 23, 2014, 1:55 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 1:55 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b186ae2322b45f16eddb762501b074a6dbeb6b11
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Bill Farner <wf...@apache.org>.
> On May 23, 2014, 8:43 p.m., Bill Farner wrote:
> > Seems like the config bar should be above the tabs, or only on the 'Active tasks' tab.
> >
> > Also, is it possible to include counts on the tab headings? I worry people will overlook problems if there's no call to action on completed, for example.
>
> David McLaughlin wrote:
> Oh, +1 on the tab counts. I had asked for that in the in-person review, but forgot it here.
>
> Suman Karumuri wrote:
> Forgot to add task counts. Added them now.
>
> The config bar is only in the Active tasks tab and the all tasks tab. Should I remove it from the all tasks tab? I kept it on the active tasks tab incase some one wanted the classic look.
> The config bar is only in the Active tasks tab and the all tasks tab.
My mistake! This LGTM.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43875
-----------------------------------------------------------
On May 23, 2014, 9:17 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 9:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
> Tabs with task counts
> https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On May 23, 2014, 8:43 p.m., Bill Farner wrote:
> > Seems like the config bar should be above the tabs, or only on the 'Active tasks' tab.
> >
> > Also, is it possible to include counts on the tab headings? I worry people will overlook problems if there's no call to action on completed, for example.
Oh, +1 on the tab counts. I had asked for that in the in-person review, but forgot it here.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43875
-----------------------------------------------------------
On May 23, 2014, 6:54 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 6:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b186ae2322b45f16eddb762501b074a6dbeb6b11
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Suman Karumuri <ma...@apache.org>.
> On May 23, 2014, 8:43 p.m., Bill Farner wrote:
> > Seems like the config bar should be above the tabs, or only on the 'Active tasks' tab.
> >
> > Also, is it possible to include counts on the tab headings? I worry people will overlook problems if there's no call to action on completed, for example.
>
> David McLaughlin wrote:
> Oh, +1 on the tab counts. I had asked for that in the in-person review, but forgot it here.
Forgot to add task counts. Added them now.
The config bar is only in the Active tasks tab and the all tasks tab. Should I remove it from the all tasks tab? I kept it on the active tasks tab incase some one wanted the classic look.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43875
-----------------------------------------------------------
On May 23, 2014, 8:54 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 8:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
> Active and completed tabs with task counts
> https://reviews.apache.org/media/uploaded/files/2014/05/23/c0434aac-e114-4502-8690-1511f4e4fac8__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> Tabs with task counts
> https://reviews.apache.org/media/uploaded/files/2014/05/23/eeef957c-521f-421f-821d-d22c3d23ff26__Screen_Shot_2014-05-23_at_1.53.41_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43875
-----------------------------------------------------------
Seems like the config bar should be above the tabs, or only on the 'Active tasks' tab.
Also, is it possible to include counts on the tab headings? I worry people will overlook problems if there's no call to action on completed, for example.
- Bill Farner
On May 23, 2014, 6:54 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 6:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b186ae2322b45f16eddb762501b074a6dbeb6b11
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43871
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On May 23, 2014, 6:54 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 6:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b186ae2322b45f16eddb762501b074a6dbeb6b11
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------
(Updated May 28, 2014, 7:25 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Rebased with master.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
-------
Moved task tables into active and completed tabs on job page.
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 5b25d52834cb3bf19dfa6ed49b35384f5c2323f2
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 9bd81601c8d0ba4296852b590d0266586e06b41b
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 9c468bdcd955ebd9d7a951094292df46f5e5bc67
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html a4b4ac7a772842311ede1e2d546cadd1d323b146
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js d52cdda655ac5a64f2520ae61808dc5562ce49e7
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js e239e7d994dff75988a45458a8a4e6f1f65c225d
Diff: https://reviews.apache.org/r/21825/diff/
Testing
-------
./gradlew run && ./gradlew build
File Attachments
----------------
active tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
completed tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/#review43882
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 23, 2014, 9:17 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21825/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 9:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-425
> https://issues.apache.org/jira/browse/AURORA-425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved task tables into active and completed tabs on job page.
> Installed angular-ui/bootstrap project since we need the tabset directive from it.
> Upgraded angular js to version 1.2.9 from 1.2.6.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
> 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
> 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
> 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
> 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
> 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
> src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
> src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
> src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
> src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039
>
> Diff: https://reviews.apache.org/r/21825/diff/
>
>
> Testing
> -------
>
> ./gradlew run && ./gradlew build
>
>
> File Attachments
> ----------------
>
> active tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
> completed tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
> all tasks tab
> https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
> Tabs with task counts
> https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------
(Updated May 23, 2014, 9:17 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
-------
Moved task tables into active and completed tabs on job page.
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.
Diffs
-----
3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039
Diff: https://reviews.apache.org/r/21825/diff/
Testing
-------
./gradlew run && ./gradlew build
File Attachments (updated)
----------------
active tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
completed tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------
(Updated May 23, 2014, 9:16 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Fixed a css glitch.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
-------
Moved task tables into active and completed tabs on job page.
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039
Diff: https://reviews.apache.org/r/21825/diff/
Testing
-------
./gradlew run && ./gradlew build
File Attachments (updated)
----------------
active tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
completed tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/eeef957c-521f-421f-821d-d22c3d23ff26__Screen_Shot_2014-05-23_at_1.53.41_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------
(Updated May 23, 2014, 8:54 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Added task counts to tabs.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
-------
Moved task tables into active and completed tabs on job page.
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039
Diff: https://reviews.apache.org/r/21825/diff/
Testing
-------
./gradlew run && ./gradlew build
File Attachments (updated)
----------------
active tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
completed tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Active and completed tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/c0434aac-e114-4502-8690-1511f4e4fac8__Screen_Shot_2014-05-22_at_6.20.25_PM.png
Tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/eeef957c-521f-421f-821d-d22c3d23ff26__Screen_Shot_2014-05-23_at_1.53.41_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21825: Added tabs for active and completed tasks in Job
page.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------
(Updated May 23, 2014, 6:54 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Addressed David's review.
Bugs: AURORA-425
https://issues.apache.org/jira/browse/AURORA-425
Repository: aurora
Description
-------
Moved task tables into active and completed tabs on job page.
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.
Diffs (updated)
-----
3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460
3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07
3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4
3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb
3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c
3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b
src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b186ae2322b45f16eddb762501b074a6dbeb6b11
Diff: https://reviews.apache.org/r/21825/diff/
Testing
-------
./gradlew run && ./gradlew build
File Attachments
----------------
active tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
completed tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Thanks,
Suman Karumuri