You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/02/09 16:30:00 UTC
[jira] [Work logged] (BEAM-13681) [Playground] Refactoring of infrastructure terraform scripts
[ https://issues.apache.org/jira/browse/BEAM-13681?focusedWorklogId=723770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723770 ]
ASF GitHub Bot logged work on BEAM-13681:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 16:29
Start Date: 09/Feb/22 16:29
Worklog Time Spent: 10m
Work Description: ilya-kozyrev commented on a change in pull request #16549:
URL: https://github.com/apache/beam/pull/16549#discussion_r802857774
##########
File path: playground/terraform/applications/backend-java/main.tf
##########
@@ -44,15 +44,15 @@ resource "google_app_engine_flexible_app_version" "backend_app" {
}
env_variables = {
- CACHE_TYPE="${var.cache_type}"
- CACHE_ADDRESS="${var.cache_address}:6379"
- NUM_PARALLEL_JOBS=10
- LAUNCH_SITE = "app_engine"
+ CACHE_TYPE = var.cache_type
+ CACHE_ADDRESS = "${var.cache_address}:6379"
Review comment:
The application submodule will be refactored in https://issues.apache.org/jira/browse/BEAM-13841 and https://issues.apache.org/jira/browse/BEAM-13842
##########
File path: playground/terraform/applications/backend-go/main.tf
##########
@@ -35,22 +35,22 @@ resource "google_app_engine_flexible_app_version" "backend_app_go" {
automatic_scaling {
max_total_instances = 7
min_total_instances = 2
- cool_down_period = "120s"
+ cool_down_period = "120s"
cpu_utilization {
target_utilization = 0.7
}
}
resources {
memory_gb = 16
- cpu = 8
+ cpu = 8
}
env_variables = {
- CACHE_TYPE="${var.cache_type}"
- CACHE_ADDRESS="${var.cache_address}:6379"
- NUM_PARALLEL_JOBS=30
- LAUNCH_SITE = "app_engine"
+ CACHE_TYPE = var.cache_type
+ CACHE_ADDRESS = "${var.cache_address}:6379"
Review comment:
The application submodule will be refactored in https://issues.apache.org/jira/browse/BEAM-13841 and https://issues.apache.org/jira/browse/BEAM-13842
##########
File path: playground/terraform/README.md
##########
@@ -62,11 +62,13 @@ Do you want to perform these actions?
Enter a value:
```
-Type `yes` and hit **Enter**. Applying the configuration could take several minutes. When it's finished, you should see `Apply complete!` along with some other information, including the number of resources created.
+Type `yes` and hit **Enter**. Applying the configuration could take several minutes. When it's finished, you should
+see `Apply complete!` along with some other information, including the number of resources created.
### Applying a non-default configuration
-You can apply a non-default Terraform configuration by changing the values in the `terraform.tfvars` file. The following variables are available:
+You can apply a non-default Terraform configuration by changing the values in the `terraform.tfvars` file. The following
+variables are available:
Review comment:
Changed.
##########
File path: playground/terraform/README.md
##########
@@ -62,11 +62,13 @@ Do you want to perform these actions?
Enter a value:
```
-Type `yes` and hit **Enter**. Applying the configuration could take several minutes. When it's finished, you should see `Apply complete!` along with some other information, including the number of resources created.
+Type `yes` and hit **Enter**. Applying the configuration could take several minutes. When it's finished, you should
+see `Apply complete!` along with some other information, including the number of resources created.
### Applying a non-default configuration
-You can apply a non-default Terraform configuration by changing the values in the `terraform.tfvars` file. The following variables are available:
+You can apply a non-default Terraform configuration by changing the values in the `terraform.tfvars` file. The following
Review comment:
Done
##########
File path: playground/terraform/README.md
##########
@@ -62,11 +62,13 @@ Do you want to perform these actions?
Enter a value:
```
-Type `yes` and hit **Enter**. Applying the configuration could take several minutes. When it's finished, you should see `Apply complete!` along with some other information, including the number of resources created.
+Type `yes` and hit **Enter**. Applying the configuration could take several minutes. When it's finished, you should
Review comment:
Changed
##########
File path: playground/terraform/README.md
##########
@@ -29,14 +29,14 @@ You'll also need to make sure that you're currently logged into your GCP account
```bash
$ gcloud auth login
```
-In other case you'll need an environment variable `GOOGLE_APPLICATION_CREDENTIALS` set to JSON key for service account that will be used to deploy resources
+
+In other case you'll need an environment variable `GOOGLE_APPLICATION_CREDENTIALS` set to JSON key for service account
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 723770)
Time Spent: 3h (was: 2h 50m)
> [Playground] Refactoring of infrastructure terraform scripts
> ------------------------------------------------------------
>
> Key: BEAM-13681
> URL: https://issues.apache.org/jira/browse/BEAM-13681
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Andrey Kustov
> Priority: P2
> Labels: beam-playground-devops
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Come up with the following terraform structure:
> # Distinguish modules (vpc, artifact_registry , memorystore (redis), bucket, Kubernet)
> # Implement the description of the modules as a script
> # Introduce module dependencies (vpc -> buckets -> artifact_registry -> memorystore -> gke)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)