You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2019/02/09 08:14:38 UTC

[GitHub] thefourtheye edited a comment on issue #87: clear response buffer with unsupported extension

thefourtheye edited a comment on issue #87: clear response buffer with unsupported extension
URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462024304
 
 
   @lgoldstein Wouldn't this make the life of the developers a bit easier?
   
   1. They don't have worry about clearing the buffer everywhere. Less code repetition.
   2. If somebody forgets to call `send*` functions without clearing the buffer, it would break. We have to rely only on the code review process to find this.
   
   Those refactoring commits are just to make sure that we don't end up with a problem like this again. I am fine with or without them.
   
   ---
   
   PS. I went looking for the expansion of LSRP. Couldn't find a satisfactory one. Now I am curious 😜 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services