You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Pedro Giffuni <pf...@apache.org> on 2011/10/12 17:53:54 UTC
Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
--- On Tue, 10/11/11, Armin Le Grand wrote:
(Concerning AGG )
>
> +1
> Let's let it go for now.
>
I plan to:
0) Apply the existing SGA on it.
1) disconnect it from the build.
2) Update it.
3) Remove it.
Pedro.
Re: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
Posted by Pedro Giffuni <pf...@apache.org>.
As promised, I committed this and AGG builds,
however after committing it looks something went wrong
and I can't re-enable it anymore.
I suspect we won't miss it but do let me know if
there's something wrong.
cheers,
Pedro.
--- On Fri, 10/14/11, Pedro Giffuni wrote:
...
>
> I have a patch that updates agg to version 2.4 and
> disables agg in configure.in, therefore bringing
> the best of both worlds without removing any code.
>
> Unfortunately it's untested and the build on my
> platform is broken, so I can't commit it yet.
>
> Pedro.
>
> ps. it's in Bugzilla 118508, if someone wants to try.
>
Re: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
Posted by Pedro Giffuni <pf...@apache.org>.
Hi;
--- On Thu, 10/13/11, Thorsten Behrens <th...@documentfoundation.org> wrote:
> Pedro Giffuni wrote:
> > AGG stays. It's used here:
> >
> > canvas/source/tools/canvastools.flt
> > canvas/source/tools/image.cxx
> >
> image.cxx is dead code as well. both can go, with agg.
>
I have a patch that updates agg to version 2.4 and
disables agg in configure.in, therefore bringing
the best of both worlds without removing any code.
Unfortunately it's untested and the build on my
platform is broken, so I can't commit it yet.
Pedro.
ps. it's in Bugzilla 118508, if someone wants to try.
Re: Anti-grain Geometry (was Re: Solve SVG visualization without
cairo and librsvg)
Posted by Thorsten Behrens <th...@documentfoundation.org>.
Pedro Giffuni wrote:
> AGG stays. It's used here:
>
> canvas/source/tools/canvastools.flt
> canvas/source/tools/image.cxx
>
image.cxx is dead code as well. both can go, with agg.
Cheers,
-- Thorsten
[code] Re: Anti-grain Geometry
Posted by Pedro Giffuni <pf...@apache.org>.
I can't test it at this time so I created a Bug 118508
in bugzilla with an experimental update.
It was really easy because the existing code already
has plugs for version 2.4.
Success or failure reports are welcome.
cheers,
Pedro.
Re: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
Posted by Pedro Giffuni <pf...@apache.org>.
--- On Thu, 10/13/11, Armin Le Grand <Ar...@me.com> wrote:
> On 13.10.2011 17:24, Pedro Giffuni wrote:
> > AGG stays. It's used here:
> >
> > canvas/source/tools/canvastools.flt
> > canvas/source/tools/image.cxx
>
> Yes, that's what I already wrote (canvas/source/tools,
> bitmap.cxx and image.cxx). Thorsten said it's not actively
> used. It's not just removing something, but to look a
> little bit deeper. Code removal often is more
> complicated than adding ;-)
>
Dumb me.. it's here: canvas/source/tools/makefile.mk
...
.IF "$(ENABLE_AGG)"=="YES"
SLOFILES += $(SLO)$/bitmap.obj \
$(SLO)$/image.obj
.IF "$(AGG_VERSION)"!=""
CDEFS += -DAGG_VERSION=$(AGG_VERSION)
.ENDIF
SHL1STDLIBS += $(AGGLIB)
.ENDIF
...
________
but then solenv/config/sooo340.ini has
ENABLE_AGG YES
This weird build system will take a time to sort out ;-).
Pedro.
> Thorsten may comment, but normally those files are not
> needed for
> building. Also ENABLE_AGG has to be removed.
>
> It's not urgently necessary due to license is okay, but
> away is away. It
> stays in the repros, though, for later eventual needs. For
> now, remove
> what can be removed...
>
> Just my 2ct,
>
> > I will probably update it though.
> > http://www.antigrain.com/news/release_notes/v24.agdoc.html#PAGE_RELEASE_V24
> >
> > cheers,
> >
> > Pedro.
> >
> > --- On Wed, 10/12/11, Pedro Giffuni wrote:
> >
> >> From: Pedro Giffuni<pf...@apache.org>
> >> Subject: Anti-grain Geometry (was Re: Solve SVG
> visualization without cairo and librsvg)
> >> To: ooo-dev@incubator.apache.org
> >> Date: Wednesday, October 12, 2011, 10:53 AM
> >>
> >> --- On Tue, 10/11/11, Armin Le Grand wrote:
> >> (Concerning AGG )
> >>
> >>>
> >>> +1
> >>> Let's let it go for now.
> >>>
> >>
> >> I plan to:
> >>
> >> 0) Apply the existing SGA on it.
> >> 1) disconnect it from the build.
> >> 2) Update it.
> >> 3) Remove it.
> >>
> >> Pedro.
> >>
> >>
> >
>
> Sincerely,
> Armin
> --
> ALG
>
>
Re: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
Posted by Pedro Giffuni <pf...@apache.org>.
--- On Thu, 10/13/11, Armin Le Grand <Ar...@me.com> wrote:
> From: Armin Le Grand <Ar...@me.com>
> Subject: Re: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
> To: ooo-dev@incubator.apache.org
> Date: Thursday, October 13, 2011, 12:35 PM
> Hi Pedro,
>
> On 13.10.2011 17:24, Pedro Giffuni wrote:
> > AGG stays. It's used here:
> >
> > canvas/source/tools/canvastools.flt
> > canvas/source/tools/image.cxx
>
> Yes, that's what I already wrote (canvas/source/tools,
> bitmap.cxx and image.cxx). Thorsten said it's not
> actively used. It's not just removing something, but
> to look a little bit deeper. Code removal often is
> more complicated than adding ;-)
>
I prefer updating over adding or removing ... and it
sounds like you would be a good candidate to test
a patch I am preparing :).
> Thorsten may comment, but normally those files are not
> needed for building. Also ENABLE_AGG has to be removed.
>
There seems to be no chance to get our hands on the
ENABLE_AGG and it seems like it never really worked
anyways so I will commit a patch to remove ENABLE_AGG
and I will add AGG to the NOTICE file.
> It's not urgently necessary due to license is okay, but
> away is away. It stays in the repros, though, for later
> eventual needs. For now, remove what can be removed...
>
Yes, I had no particular interest in shooting it down
now, I just thought I could save a few cycles if it
was dead code.
cheers,
Pedro.
> Just my 2ct,
>
> > I will probably update it though.
> > http://www.antigrain.com/news/release_notes/v24.agdoc.html#PAGE_RELEASE_V24
> >
> > cheers,
> >
> > Pedro.
> >
Re: Anti-grain Geometry (was Re: Solve SVG visualization without
cairo and librsvg)
Posted by Armin Le Grand <Ar...@me.com>.
Hi Pedro,
On 13.10.2011 17:24, Pedro Giffuni wrote:
> AGG stays. It's used here:
>
> canvas/source/tools/canvastools.flt
> canvas/source/tools/image.cxx
Yes, that's what I already wrote (canvas/source/tools, bitmap.cxx and
image.cxx). Thorsten said it's not actively used. It's not just removing
something, but to look a little bit deeper. Code removal often is more
complicated than adding ;-)
Thorsten may comment, but normally those files are not needed for
building. Also ENABLE_AGG has to be removed.
It's not urgently necessary due to license is okay, but away is away. It
stays in the repros, though, for later eventual needs. For now, remove
what can be removed...
Just my 2ct,
> I will probably update it though.
> http://www.antigrain.com/news/release_notes/v24.agdoc.html#PAGE_RELEASE_V24
>
> cheers,
>
> Pedro.
>
> --- On Wed, 10/12/11, Pedro Giffuni wrote:
>
>> From: Pedro Giffuni<pf...@apache.org>
>> Subject: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
>> To: ooo-dev@incubator.apache.org
>> Date: Wednesday, October 12, 2011, 10:53 AM
>>
>> --- On Tue, 10/11/11, Armin Le Grand wrote:
>> (Concerning AGG )
>>
>>>
>>> +1
>>> Let's let it go for now.
>>>
>>
>> I plan to:
>>
>> 0) Apply the existing SGA on it.
>> 1) disconnect it from the build.
>> 2) Update it.
>> 3) Remove it.
>>
>> Pedro.
>>
>>
>
Sincerely,
Armin
--
ALG
Re: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
Posted by Pedro Giffuni <pf...@apache.org>.
AGG stays. It's used here:
canvas/source/tools/canvastools.flt
canvas/source/tools/image.cxx
I will probably update it though.
http://www.antigrain.com/news/release_notes/v24.agdoc.html#PAGE_RELEASE_V24
cheers,
Pedro.
--- On Wed, 10/12/11, Pedro Giffuni wrote:
> From: Pedro Giffuni <pf...@apache.org>
> Subject: Anti-grain Geometry (was Re: Solve SVG visualization without cairo and librsvg)
> To: ooo-dev@incubator.apache.org
> Date: Wednesday, October 12, 2011, 10:53 AM
>
> --- On Tue, 10/11/11, Armin Le Grand wrote:
> (Concerning AGG )
>
> >
> > +1
> > Let's let it go for now.
> >
>
> I plan to:
>
> 0) Apply the existing SGA on it.
> 1) disconnect it from the build.
> 2) Update it.
> 3) Remove it.
>
> Pedro.
>
>