You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/05 07:28:43 UTC

[jira] Created: (HARMONY-303) isAnyAddress is a function not a variable in win.IA32/port/hysock.c

isAnyAddress is a function not a variable in win.IA32/port/hysock.c
-------------------------------------------------------------------

         Key: HARMONY-303
         URL: http://issues.apache.org/jira/browse/HARMONY-303
     Project: Harmony
        Type: Bug

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Minor


Code references to isAnyAddress in an if condition - but it is a function not a variable so it always evaluates true.  The result of the call should be used instead ... and it is calculated earlier in the function as anyAddress.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (HARMONY-303) isAnyAddress is a function not a variable in win.IA32/port/hysock.c

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.

     [ http://issues.apache.org/jira/browse/HARMONY-303?page=all ]
     
Tim Ellison resolved HARMONY-303:
---------------------------------

    Resolution: Fixed

Thanks Mark,

Fixed in win.IA32/port/hysock.c at repo revision 391677.

Please check that the patch was applied as you expected.


> isAnyAddress is a function not a variable in win.IA32/port/hysock.c
> -------------------------------------------------------------------
>
>          Key: HARMONY-303
>          URL: http://issues.apache.org/jira/browse/HARMONY-303
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: isanyaddress.is.a.function.diff
>
> Code references to isAnyAddress in an if condition - but it is a function not a variable so it always evaluates true.  The result of the call should be used instead ... and it is calculated earlier in the function as anyAddress.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (HARMONY-303) isAnyAddress is a function not a variable in win.IA32/port/hysock.c

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.

    [ http://issues.apache.org/jira/browse/HARMONY-303?page=comments#action_12373419 ] 

Mark Hindess commented on HARMONY-303:
--------------------------------------

Looks good.  Thanks Tim.

> isAnyAddress is a function not a variable in win.IA32/port/hysock.c
> -------------------------------------------------------------------
>
>          Key: HARMONY-303
>          URL: http://issues.apache.org/jira/browse/HARMONY-303
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: isanyaddress.is.a.function.diff
>
> Code references to isAnyAddress in an if condition - but it is a function not a variable so it always evaluates true.  The result of the call should be used instead ... and it is calculated earlier in the function as anyAddress.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (HARMONY-303) isAnyAddress is a function not a variable in win.IA32/port/hysock.c

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.

     [ http://issues.apache.org/jira/browse/HARMONY-303?page=all ]
     
Tim Ellison closed HARMONY-303:
-------------------------------


Verified by Mark


> isAnyAddress is a function not a variable in win.IA32/port/hysock.c
> -------------------------------------------------------------------
>
>          Key: HARMONY-303
>          URL: http://issues.apache.org/jira/browse/HARMONY-303
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: isanyaddress.is.a.function.diff
>
> Code references to isAnyAddress in an if condition - but it is a function not a variable so it always evaluates true.  The result of the call should be used instead ... and it is calculated earlier in the function as anyAddress.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (HARMONY-303) isAnyAddress is a function not a variable in win.IA32/port/hysock.c

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.

     [ http://issues.apache.org/jira/browse/HARMONY-303?page=all ]

Mark Hindess updated HARMONY-303:
---------------------------------

    Attachment: isanyaddress.is.a.function.diff

Patch with fix.


> isAnyAddress is a function not a variable in win.IA32/port/hysock.c
> -------------------------------------------------------------------
>
>          Key: HARMONY-303
>          URL: http://issues.apache.org/jira/browse/HARMONY-303
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: isanyaddress.is.a.function.diff
>
> Code references to isAnyAddress in an if condition - but it is a function not a variable so it always evaluates true.  The result of the call should be used instead ... and it is calculated earlier in the function as anyAddress.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (HARMONY-303) isAnyAddress is a function not a variable in win.IA32/port/hysock.c

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.

     [ http://issues.apache.org/jira/browse/HARMONY-303?page=all ]

Tim Ellison reassigned HARMONY-303:
-----------------------------------

    Assign To: Tim Ellison

> isAnyAddress is a function not a variable in win.IA32/port/hysock.c
> -------------------------------------------------------------------
>
>          Key: HARMONY-303
>          URL: http://issues.apache.org/jira/browse/HARMONY-303
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: isanyaddress.is.a.function.diff
>
> Code references to isAnyAddress in an if condition - but it is a function not a variable so it always evaluates true.  The result of the call should be used instead ... and it is calculated earlier in the function as anyAddress.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira