[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

["urbandan (via GitHub)" <gi...@apache.org>]

urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1185797643


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -424,6 +477,11 @@ ProducerIdAndEpoch producerIdAndEpoch() {
     }
 
     synchronized public void maybeUpdateProducerIdAndEpoch(TopicPartition topicPartition) {
+        if (hasFatalError()) {

Review Comment:
   @kirktrue I agree, it's better to not mutate the state after we encountered a fatal error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org