You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/11 02:27:25 UTC

[GitHub] [incubator-tvm] cclauss opened a new pull request #4686: Use ==/!= to compare str, bytes, and int literals

cclauss opened a new pull request #4686: Use ==/!= to compare str, bytes, and int literals
URL: https://github.com/apache/incubator-tvm/pull/4686
 
 
   Identity is not the same thing as equality in Python so use ==/!= to compare str, bytes, and int literals. In Python >= 3.8, these instances will raise __SyntaxWarnings__ so it is best to fix them now. https://docs.python.org/3.8/whatsnew/3.8.html#porting-to-python-3-8
   
   % __python__
   ```
   >>> dtype = "float"
   >>> dtype += "16"
   >>> dtype == "float16"
   True
   >>> dtype is "float16"
   False
   >>> 0 == 0.0
   True
   >>> 0 is 0.0
   False
   ```
   
   Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4686: Use ==/!= to compare str, bytes, and int literals

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4686: Use ==/!= to compare str, bytes, and int literals
URL: https://github.com/apache/incubator-tvm/pull/4686
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services