You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/03/03 19:50:04 UTC
Review Request 18699: Added PicoJSON.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
Diff: https://reviews.apache.org/r/18699/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 18699: Added PicoJSON.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/#review36041
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2014, 6:50 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18699/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 6:50 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
> 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
>
> Diff: https://reviews.apache.org/r/18699/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18699: Added PicoJSON.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/#review36115
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 3, 2014, 10:12 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18699/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 10:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Timothy St. Clair, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
> 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
>
> Diff: https://reviews.apache.org/r/18699/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18699: Added PicoJSON.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 3, 2014, 11:33 p.m., Charlie Carson wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 39
> > <https://reviews.apache.org/r/18699/diff/1/?file=508461#file508461line39>
> >
> > sorted order to make diff's / merge conflicts easier?
I'm going to defer to another review to sort all of these.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/#review36051
-----------------------------------------------------------
On March 3, 2014, 10:12 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18699/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 10:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Timothy St. Clair, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
> 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
>
> Diff: https://reviews.apache.org/r/18699/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18699: Added PicoJSON.
Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/#review36051
-----------------------------------------------------------
Ship it!
Ship It!
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/18699/#comment66877>
sorted order to make diff's / merge conflicts easier?
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/18699/#comment66878>
sorted?
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/18699/#comment66879>
sorted
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/18699/#comment66880>
sorted
3rdparty/libprocess/3rdparty/versions.am
<https://reviews.apache.org/r/18699/#comment66881>
sorted
- Charlie Carson
On March 3, 2014, 10:12 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18699/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 10:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Timothy St. Clair, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
> 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
>
> Diff: https://reviews.apache.org/r/18699/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18699: Added PicoJSON.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/#review36361
-----------------------------------------------------------
Ship it!
The dep addition seems fine. I can easily add to downstream, and modify.
At a higher layer though, I think it makes sense to start to evaluate: https://issues.apache.org/jira/browse/MESOS-1022 as it relates to dependency management.
- Timothy St. Clair
On March 3, 2014, 10:12 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18699/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 10:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Timothy St. Clair, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
> 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
>
> Diff: https://reviews.apache.org/r/18699/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18699: Added PicoJSON.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18699/
-----------------------------------------------------------
(Updated March 3, 2014, 10:12 p.m.)
Review request for mesos, Ben Mahler, Timothy St. Clair, and Vinod Kone.
Changes
-------
Added Tim to the reviews.
Tim: PicoJSON is header only. Let me know if it would be helpful to followup with another patch that makes extracting and including the extracted PicoJSON optional (similar to our --without-included-zookeeper) in order to make packaging easier.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 51b118c48ad51624d5607793fb2dcab40b10adde
3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 7061e908127538ffa601d672be02ea77c36894b0
Diff: https://reviews.apache.org/r/18699/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman