[GitHub] sreev opened a new issue #3046: fix rounding error failing build

[GitBox <gi...@apache.org>]

sreev opened a new issue #3046: fix rounding error failing build
URL: https://github.com/apache/incubator-heron/issues/3046
 
 
   ```
   ERROR: /Users/svaddi/SreeVaddi/source/github/sreev/incubator-heron/heron/common/src/java/BUILD:11:1: Building heron/common/src/java/libbasics-java.jar (13 source files) failed (Exit 1)
   heron/common/src/java/org/apache/heron/common/basics/ByteAmount.java:28: error: [MathRoundIntLong] Math.round(Integer) results in truncation
     private static final long MAX_MB = Math.round(Long.MAX_VALUE / MB);
                                                  ^
       (see https://errorprone.info/bugpattern/MathRoundIntLong)
     Did you mean 'private static final long MAX_MB = Ints.saturatedCast(Long.MAX_VALUE / MB);'?
   heron/common/src/java/org/apache/heron/common/basics/ByteAmount.java:29: error: [MathRoundIntLong] Math.round(Integer) results in truncation
     private static final long MAX_GB = Math.round(Long.MAX_VALUE / GB);
                                                  ^
       (see https://errorprone.info/bugpattern/MathRoundIntLong)
     Did you mean 'private static final long MAX_GB = Ints.saturatedCast(Long.MAX_VALUE / GB);'?
   INFO: Elapsed time: 198.003s, Critical Path: 137.34s
   INFO: 454 processes: 446 local, 8 worker.
   FAILED: Build did NOT complete successfully
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services