You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/21 12:06:38 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network

DaanHoogland commented on pull request #4600:
URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-764598789


   nice cleanup, but shouldn't `removed` in the `listDistinctHostNames()` still be `null`? I.E. teh line 282 remain
   ```
       DistinctHostNameSearch.and("removed", DistinctHostNameSearch.entity().getRemoved(), SearchCriteria.Op.NULL);
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org