[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #10327: [IOTDB-6028] Fix SonarCloud code smells in consensus module

["SzyWilliam (via GitHub)" <gi...@apache.org>]

SzyWilliam commented on code in PR #10327:
URL: https://github.com/apache/iotdb/pull/10327#discussion_r1243467642


##########
consensus/src/main/java/org/apache/iotdb/consensus/ratis/ApplicationStateMachineProxy.java:
##########
@@ -163,7 +164,7 @@ public CompletableFuture<Message> applyTransaction(TransactionContext trx) {
       } catch (InterruptedException i) {
         logger.warn("{} interrupted when retry sleep", this);
         Thread.currentThread().interrupt();
-      } catch (Throwable rte) {

Review Comment:
   Throwable here is better. We need to catch RunTimeExceptions so that the SM can still works under some rare scenarios.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org