You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2019/04/06 14:53:00 UTC

[jira] [Comment Edited] (HTTPCLIENT-1981) HttpTrace should not accept an entity

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811578#comment-16811578 ] 

Oleg Kalnichevski edited comment on HTTPCLIENT-1981 at 4/6/19 2:52 PM:
-----------------------------------------------------------------------

[~jaymode] Please review the following change-set in HttpCore and let me know if it makes sense to you

https://github.com/apache/httpcomponents-core/commits/HTTPCLIENT-1981

I'll commit your patch to HttpClient as the next step.

Oleg


was (Author: olegk):
[~jaymode] Please review the following change-set in HttpCore and let me know if it makes sense to you

https://github.com/apache/httpcomponents-core/commit/cf7ef3a6a0a84615bf617d02ed5f19e297956496

I'll commit your patch to HttpClient as the next step.

Oleg

> HttpTrace should not accept an entity
> -------------------------------------
>
>                 Key: HTTPCLIENT-1981
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1981
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 5.0 Beta3
>            Reporter: Jay Modi
>            Priority: Major
>         Attachments: http_trace_no_entity.diff
>
>
> The HttpTrace class allows a user to set an entity, but both RFC 2616 and RFC 7231 state that the client MUST NOT send an entity/message body. I've attached a patch that throws an UnsupportedOperationException for trace requests in two places but maybe there is a better place/way to handle this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org