You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@davidglasser.net> on 2007/11/27 18:09:11 UTC
Case-sensitivity test (Re: svn commit: r28073 - trunk/subversion/libsvn_fs_util)
I'd love to see a test for the problem that this revision fixes, but
I'm not familiar enough with svn log -g (the only command that tests a
codepath with LIKE) to reproduce it myself (let alone write a
programmatic test). Anybody want to give it a shot?
--dave
On Nov 27, 2007 10:05 AM, <gl...@tigris.org> wrote:
> Author: glasser
> Date: Tue Nov 27 10:05:54 2007
> New Revision: 28073
>
> Log:
> We make at least one LIKE query against paths, to find paths that are
> children of a given path. This really really really needs to be
> case-sensitive!
>
> * subversion/libsvn_fs_util/sqlite-util.c
> (schema_create_sql): Make all LIKEs case-sensitive when the database
> is created.
>
>
> Modified:
> trunk/subversion/libsvn_fs_util/sqlite-util.c
>
> Modified: trunk/subversion/libsvn_fs_util/sqlite-util.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_util/sqlite-util.c?pathrev=28073&r1=28072&r2=28073
> ==============================================================================
> --- trunk/subversion/libsvn_fs_util/sqlite-util.c (original)
> +++ trunk/subversion/libsvn_fs_util/sqlite-util.c Tue Nov 27 10:05:54 2007
> @@ -93,6 +93,8 @@
> /* USER_VERSION 1 */
> "PRAGMA auto_vacuum = 1;"
> APR_EOL_STR
> + "PRAGMA case_sensitive_like=on;"
> + APR_EOL_STR
> "CREATE TABLE mergeinfo (revision INTEGER NOT NULL, mergedfrom TEXT NOT "
> "NULL, mergedto TEXT NOT NULL, mergedrevstart INTEGER NOT NULL, "
> "mergedrevend INTEGER NOT NULL, inheritable INTEGER NOT NULL);"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Case-sensitivity test (Re: svn commit: r28073 - trunk/subversion/libsvn_fs_util)
Posted by David Glasser <gl...@davidglasser.net>.
In fact, given that this revision was broken (hopefully r28077 is more
correct), yeah, tests would be nice :-)
--dave
On Nov 27, 2007 10:09 AM, David Glasser <gl...@davidglasser.net> wrote:
> I'd love to see a test for the problem that this revision fixes, but
> I'm not familiar enough with svn log -g (the only command that tests a
> codepath with LIKE) to reproduce it myself (let alone write a
> programmatic test). Anybody want to give it a shot?
>
> --dave
>
> On Nov 27, 2007 10:05 AM, <gl...@tigris.org> wrote:
> > Author: glasser
> > Date: Tue Nov 27 10:05:54 2007
> > New Revision: 28073
> >
> > Log:
> > We make at least one LIKE query against paths, to find paths that are
> > children of a given path. This really really really needs to be
> > case-sensitive!
> >
> > * subversion/libsvn_fs_util/sqlite-util.c
> > (schema_create_sql): Make all LIKEs case-sensitive when the database
> > is created.
> >
> >
> > Modified:
> > trunk/subversion/libsvn_fs_util/sqlite-util.c
> >
> > Modified: trunk/subversion/libsvn_fs_util/sqlite-util.c
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_util/sqlite-util.c?pathrev=28073&r1=28072&r2=28073
> > ==============================================================================
> > --- trunk/subversion/libsvn_fs_util/sqlite-util.c (original)
> > +++ trunk/subversion/libsvn_fs_util/sqlite-util.c Tue Nov 27 10:05:54 2007
> > @@ -93,6 +93,8 @@
> > /* USER_VERSION 1 */
> > "PRAGMA auto_vacuum = 1;"
> > APR_EOL_STR
> > + "PRAGMA case_sensitive_like=on;"
> > + APR_EOL_STR
> > "CREATE TABLE mergeinfo (revision INTEGER NOT NULL, mergedfrom TEXT NOT "
> > "NULL, mergedto TEXT NOT NULL, mergedrevstart INTEGER NOT NULL, "
> > "mergedrevend INTEGER NOT NULL, inheritable INTEGER NOT NULL);"
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> > For additional commands, e-mail: svn-help@subversion.tigris.org
> >
> >
>
>
>
> --
> David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
>
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org