You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/01/06 09:22:55 UTC

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #2721: [type:refactor] modify null judgment

codecov-commenter commented on pull request #2721:
URL: https://github.com/apache/incubator-shenyu/pull/2721#issuecomment-1006405018


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2721](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39397be) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53c0ca0b327001e31a9238d433a6eb6fd9c6c727?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53c0ca0) will **decrease** coverage by `0.55%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2721      +/-   ##
   ============================================
   - Coverage     60.33%   59.78%   -0.56%     
   + Complexity     4394     4366      -28     
   ============================================
     Files           680      680              
     Lines         19469    19466       -3     
     Branches       1725     1725              
   ============================================
   - Hits          11747    11637     -110     
   - Misses         6732     6853     +121     
   + Partials        990      976      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../apache/shenyu/admin/model/page/PageParameter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvcGFnZS9QYWdlUGFyYW1ldGVyLmphdmE=) | `78.26% <0.00%> (ø)` | |
   | [...pache/shenyu/admin/model/page/PageResultUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvcGFnZS9QYWdlUmVzdWx0VXRpbHMuamF2YQ==) | `66.66% <0.00%> (ø)` | |
   | [.../admin/service/impl/DataPermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0RhdGFQZXJtaXNzaW9uU2VydmljZUltcGwuamF2YQ==) | `90.27% <100.00%> (-0.14%)` | :arrow_down: |
   | [...n/java/org/apache/shenyu/admin/utils/AesUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvQWVzVXRpbHMuamF2YQ==) | `85.71% <100.00%> (+14.28%)` | :arrow_up: |
   | [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.75% <0.00%> (-31.25%)` | :arrow_down: |
   | [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.03% <0.00%> (-29.12%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `61.38% <0.00%> (-11.89%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
   | [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
   | [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
   | ... and [29 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2721/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53c0ca0...39397be](https://codecov.io/gh/apache/incubator-shenyu/pull/2721?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org