[GitHub] [superset] rusackas commented on pull request #12593: chore(explore): Save Resizable width to localStorage

[GitBox <gi...@apache.org>]

rusackas commented on pull request #12593:
URL: https://github.com/apache/superset/pull/12593#issuecomment-763393075


   As to @ktmud's point, I agree the two panes should be sizeable independently, and have their values stored independently. You could save them together as he proposes here, or with two getter/setters. Whatever seems cleaner.
   
   The bigger issue to me with the current state of the PR is what's seen in the description GIF. If you make the data source panel wide, the controls panel does not scale (this is fine). However, when you refresh, the controls panel is big, too.
   
   Resizing the controls panel (at the line to the right of it) yeilds unpredictable results as well. It seems like whether the controls panel is small, medium or large, if you widen the controls panel, and then refresh, both columns become full width.
   
   https://user-images.githubusercontent.com/812905/105140407-80666100-5aac-11eb-9292-36cd349f9608.mp4
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org