You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/13 10:02:42 UTC
Review Request 46140: Some clean up in allocator test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Some clean up in allocator test.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 5e60cb6a7da973da7741248f3d2bf4c25330a6ea
Diff: https://reviews.apache.org/r/46140/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 46140: Some clean up in allocator test.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review128655
-----------------------------------------------------------
Bad patch!
Reviews applied: [46140]
Failed command: ./support/apply-review.sh -n -r 46140
Error:
2016-04-13 12:22:01 URL:https://reviews.apache.org/r/46140/diff/raw/ [1222/1222] -> "46140.patch" [1]
error: patch failed: src/tests/hierarchical_allocator_tests.cpp:3037
error: src/tests/hierarchical_allocator_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12503/console
- Mesos ReviewBot
On April 13, 2016, 8:02 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 8:02 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some clean up in allocator test.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 5e60cb6a7da973da7741248f3d2bf4c25330a6ea
>
> Diff: https://reviews.apache.org/r/46140/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46140: WIP: Added dvd isolator test
"ROOT_LaunchCommandExecutorWithVolumes".
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review130818
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46680, 46681, 46682, 46140]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 27, 2016, 4:28 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 4:28 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added dvd isolator test "ROOT_LaunchCommandExecutorWithVolumes".
>
>
> Diffs
> -----
>
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 070d52018e82ed3e46fb1b79714ffc4716f6a306
> src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46140/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46140: WIP: Added dvd isolator test
"ROOT_LaunchCommandExecutorWithVolumes".
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/
-----------------------------------------------------------
(Updated 四月 27, 2016, 4:28 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Summary (updated)
-----------------
WIP: Added dvd isolator test "ROOT_LaunchCommandExecutorWithVolumes".
Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266
Repository: mesos
Description (updated)
-------
WIP: Added dvd isolator test "ROOT_LaunchCommandExecutorWithVolumes".
Diffs (updated)
-----
src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 070d52018e82ed3e46fb1b79714ffc4716f6a306
src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46140/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu