You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/08/13 21:54:59 UTC
Review Request 68324: Added two agent flags for min/max
authentication retry interval.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Bugs: MESOS-9146
https://issues.apache.org/jira/browse/MESOS-9146
Repository: mesos
Description
-------
`flags.min_authentication_retry_interval` controls the
minimum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
`flags.max_authentication_retry_interval` controls the
maximum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
Diffs
-----
docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
Diff: https://reviews.apache.org/r/68324/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207182
-----------------------------------------------------------
PASS: Mesos patch 68324 was successfully built and tested.
Reviews applied: `['68304', '68324']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2140/mesos-review-68324
- Mesos Reviewbot Windows
On Aug. 13, 2018, 2:54 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 2:54 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `flags.min_authentication_retry_interval` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> `flags.max_authentication_retry_interval` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207212
-----------------------------------------------------------
PASS: Mesos patch 68324 was successfully built and tested.
Reviews applied: `['68304', '68324']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2146/mesos-review-68324
- Mesos Reviewbot Windows
On Aug. 14, 2018, 5:37 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 5:37 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `flags.authentication_timeout_min` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> `flags.authentication_timeout_max` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207234
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68304, 68324]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 14, 2018, 5:37 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 5:37 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `flags.authentication_timeout_min` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> `flags.authentication_timeout_max` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207365
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/flags.cpp
Lines 356-362 (original), 356-362 (patched)
<https://reviews.apache.org/r/68324/#comment290739>
If you update this description, please make sure to keep `agent.md` and `authentication.md` in sync.
src/slave/slave.cpp
Line 1427 (original), 1427 (patched)
<https://reviews.apache.org/r/68324/#comment290740>
s/, We cap/, we cap/
- Gastón Kleiman
On Aug. 15, 2018, 11:49 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2018, 11:49 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> flags.authentication_timeout_min controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> flags.authentication_timeout_max controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/
-----------------------------------------------------------
(Updated Aug. 16, 2018, 1:54 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Changes
-------
Rebased.
Bugs: MESOS-9146
https://issues.apache.org/jira/browse/MESOS-9146
Repository: mesos
Description
-------
flags.authentication_timeout_min controls the
minimum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
flags.authentication_timeout_max controls the
maximum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
Diffs (updated)
-----
docs/authentication.md f8fc6a93b312cbcaac8eeae121cedfccd830af9a
docs/configuration/agent.md 746a3e83f790668983a6c4ea0d6a4c10e0421f86
src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
src/slave/flags.hpp 0d1dac8775c74dd625eeafce489ece7cfb32af21
src/slave/flags.cpp f1727cd5b05a122f52775a54208e097b07603239
src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
src/tests/authentication_tests.cpp 0e8a758ff5061541576317ced079fc59c728f246
Diff: https://reviews.apache.org/r/68324/diff/6/
Changes: https://reviews.apache.org/r/68324/diff/5-6/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 3:48 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Bugs: MESOS-9146
https://issues.apache.org/jira/browse/MESOS-9146
Repository: mesos
Description
-------
flags.authentication_timeout_min controls the
minimum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
flags.authentication_timeout_max controls the
maximum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
Diffs (updated)
-----
docs/authentication.md ab3791b7d0c52826213f735b4acf5627b2925330
docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
Diff: https://reviews.apache.org/r/68324/diff/5/
Changes: https://reviews.apache.org/r/68324/diff/4-5/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207359
-----------------------------------------------------------
Fix it, then Ship it!
docs/configuration/agent.md
Lines 232-241 (original), 232-266 (patched)
<https://reviews.apache.org/r/68324/#comment290727>
Can you also update authentication.md?
Be sure to update it with your new changes :)
src/slave/flags.cpp
Lines 356-362 (original), 356-362 (patched)
<https://reviews.apache.org/r/68324/#comment290730>
The original comment seems more readable to me, and the new one still seems interval oriented rather than timeout oriented? Here's a suggestion:
```
The agent will time out its authentication with the master
based on exponentional backoff. The timeout will be randomly
chosen within the range [min, min + factor*2^n] where n is the
number of failed attempts. To tune these parameters, set the
`--authentication_timeout_[min|max|factor]` flags.
```
src/slave/flags.cpp
Lines 369 (patched)
<https://reviews.apache.org/r/68324/#comment290729>
`s/NOTE:/Note that/`
src/slave/slave.cpp
Line 1296 (original), 1296 (patched)
<https://reviews.apache.org/r/68324/#comment290726>
/+/ +/
- Benjamin Mahler
On Aug. 15, 2018, 6:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2018, 6:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> flags.authentication_timeout_min controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> flags.authentication_timeout_max controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 11:49 a.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Changes
-------
Rebased.
Bugs: MESOS-9146
https://issues.apache.org/jira/browse/MESOS-9146
Repository: mesos
Description
-------
flags.authentication_timeout_min controls the
minimum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
flags.authentication_timeout_max controls the
maximum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
Diffs (updated)
-----
docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
Diff: https://reviews.apache.org/r/68324/diff/4/
Changes: https://reviews.apache.org/r/68324/diff/3-4/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/
-----------------------------------------------------------
(Updated Aug. 14, 2018, 5:47 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Bugs: MESOS-9146
https://issues.apache.org/jira/browse/MESOS-9146
Repository: mesos
Description (updated)
-------
flags.authentication_timeout_min controls the
minimum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
flags.authentication_timeout_max controls the
maximum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
Diffs (updated)
-----
docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
Diff: https://reviews.apache.org/r/68324/diff/3/
Changes: https://reviews.apache.org/r/68324/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/
-----------------------------------------------------------
(Updated Aug. 13, 2018, 10:37 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Bugs: MESOS-9146
https://issues.apache.org/jira/browse/MESOS-9146
Repository: mesos
Description (updated)
-------
`flags.authentication_timeout_min` controls the
minimum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
`flags.authentication_timeout_max` controls the
maximum amount of time the agent waits before retrying
authenticating with the master after a failed attempt.
Diffs (updated)
-----
docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
Diff: https://reviews.apache.org/r/68324/diff/2/
Changes: https://reviews.apache.org/r/68324/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Aug. 13, 2018, 4:14 p.m., Benjamin Mahler wrote:
> > src/slave/flags.cpp
> > Lines 365-380 (patched)
> > <https://reviews.apache.org/r/68324/diff/1/?file=2072099#file2072099line365>
> >
> > Maybe we should start these with `authentication`? How about:
> >
> > ```
> > authentication_timeout_min
> > authentication_timeout_max
> > ```
> >
> > I think these will be more easily understood and they're easier to find alongside other "authentication" prefixed flags?
Done.
I was thinking of being consistent with the seeming convention of putting min/max at the beginning (see master flags). But I agree that your suggestion can be better understood.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207178
-----------------------------------------------------------
On Aug. 13, 2018, 10:37 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:37 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `flags.authentication_timeout_min` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> `flags.authentication_timeout_max` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207178
-----------------------------------------------------------
src/slave/flags.cpp
Lines 365-380 (patched)
<https://reviews.apache.org/r/68324/#comment290475>
Maybe we should start these with `authentication`? How about:
```
authentication_timeout_min
authentication_timeout_max
```
I think these will be more easily understood and they're easier to find alongside other "authentication" prefixed flags?
src/slave/flags.cpp
Lines 369-370 (patched)
<https://reviews.apache.org/r/68324/#comment290474>
for more details. Note that since ...
- Benjamin Mahler
On Aug. 13, 2018, 9:54 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 9:54 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `flags.min_authentication_retry_interval` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> `flags.max_authentication_retry_interval` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68324: Added two agent flags for min/max
authentication retry interval.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207208
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68304, 68324]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 13, 2018, 9:54 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 9:54 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9146
> https://issues.apache.org/jira/browse/MESOS-9146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `flags.min_authentication_retry_interval` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
> `flags.max_authentication_retry_interval` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb
> src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9
> src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c
> src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9
> src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c
> src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9
>
>
> Diff: https://reviews.apache.org/r/68324/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>