You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "gaborkaszab (via GitHub)" <gi...@apache.org> on 2025/01/21 16:46:57 UTC
[PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
gaborkaszab opened a new pull request, #12022:
URL: https://github.com/apache/iceberg/pull/12022
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#discussion_r1951282205
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2978,6 +2979,20 @@ components:
items:
type: integer
+ RemoveSchemasUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - schema-ids
Review Comment:
Is there a set of updated schema ids or a set of removed schema ids? I guess the later. Just to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#discussion_r1951314200
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2978,6 +2979,20 @@ components:
items:
type: integer
+ RemoveSchemasUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - schema-ids
Review Comment:
Set of schemas to remove from the table by ID, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #12022:
URL: https://github.com/apache/iceberg/pull/12022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#issuecomment-2605249321
Similarly to removing unused specs, I started working on removing unused schemas. This PR is similar to https://github.com/apache/iceberg/pull/10846
As an author of the other PR, @amogh-jahagirdar would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#discussion_r1951282205
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2978,6 +2979,20 @@ components:
items:
type: integer
+ RemoveSchemasUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - schema-ids
Review Comment:
Is there a set of updated schema ids or a set of removed schema ids?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#discussion_r1947539349
##########
open-api/rest-catalog-open-api.py:
##########
@@ -390,6 +390,11 @@ class RemovePartitionSpecsUpdate(BaseUpdate):
spec_ids: List[int] = Field(..., alias='spec-ids')
+class RemoveSchemasUpdate(BaseUpdate):
+ action: Optional[Literal['remove-schemas']] = None
Review Comment:
why this is optional? Looks like all other actions are constant field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#discussion_r1951686336
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2978,6 +2979,20 @@ components:
items:
type: integer
+ RemoveSchemasUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - schema-ids
Review Comment:
Yes this is a set of schemas to remove by ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#issuecomment-2638983371
cc @advancedxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#issuecomment-2659113436
Thanks @gaborkaszab , thanks @advancedxy @rdblue @flyrain @nastra @stevenzwu for reviewing! I'll go ahead and merge since the vote passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #12022:
URL: https://github.com/apache/iceberg/pull/12022#discussion_r1948931896
##########
open-api/rest-catalog-open-api.py:
##########
@@ -390,6 +390,11 @@ class RemovePartitionSpecsUpdate(BaseUpdate):
spec_ids: List[int] = Field(..., alias='spec-ids')
+class RemoveSchemasUpdate(BaseUpdate):
+ action: Optional[Literal['remove-schemas']] = None
Review Comment:
Good catch! There have been an [OpenAPI version bump](https://github.com/apache/iceberg/commit/8cd5b1985d3f9c55ab2ced174559a8416b6ca1b4) since I uploaded this PR and changed the type of these updates from enum to const. As a result the generated py file no longer has the action as optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org