You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Carlos Rovira <ca...@apache.org> on 2020/04/09 07:44:35 UTC
Using SNAPSHOTS and self patched code (was Re: [royale-asjs.wiki]
branch master updated: Updated CI Server Setup (markdown))
Hi Alex,
using SNAPSHOTS of external software with self-patched code is something
that is not the right way to go for any project and we shouldn't allow in
Apache Royale too.
Not releasing with snapshot dependencies is something that's in Maven
official documentation [1] as something we must honor and for that reason
it's normal we don' have that our own docs.
I must say that don't understand the use of JGIT since we exposed that is
not necessary reaching step 7 without problem.
I'm not ok with using that. So please, can you remove it and use and
official way to get what you want?.
Thanks
[1]
https://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html
El jue., 9 abr. 2020 a las 8:28, <ah...@apache.org> escribió:
>
> +We are currently using maven-scm-provider-jgit with the patch for
> [SCM-932](https://issues.apache.org/jira/browse/SCM-932). We are calling
> it version 1.13.0-SNAPSHOT
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: Using SNAPSHOTS and self patched code (was Re: [royale-asjs.wiki]
branch master updated: Updated CI Server Setup (markdown))
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
El vie., 10 abr. 2020 a las 7:04, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> In accordance with Maven's release philosophy, Royale code will not have
> any snapshot versions on the staging or release repos nor will the jars and
> swcs depend on snapshot versions. The CI profile will use a snapshot
> version of JGit unless Maven decides to release it before we get our
> release out. That seems to be allowed by Maven's release plugin. It only
> cares about the artifacts we release, not the plugins used to create the
> artifacts.
>
>
ok, I thought it need to be free of snapshots at all
> We need JGit in order to not store someone's credentials on a shared
> machine.
>
>
if the problem is storing credentials in the CI Server, I think that could
be solved just by making people using the CI server remove credentials as
finish his RM work there. I mean, imposing that conduct as the final part
of the operations in the CI should ok.
just my 2...
> -Alex
>
> On 4/9/20, 12:44 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> Hi Alex,
>
> using SNAPSHOTS of external software with self-patched code is
> something
> that is not the right way to go for any project and we shouldn't allow
> in
> Apache Royale too.
>
> Not releasing with snapshot dependencies is something that's in Maven
> official documentation [1] as something we must honor and for that
> reason
> it's normal we don' have that our own docs.
>
> I must say that don't understand the use of JGIT since we exposed that
> is
> not necessary reaching step 7 without problem.
>
> I'm not ok with using that. So please, can you remove it and use and
> official way to get what you want?.
>
> Thanks
>
> [1]
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmaven.apache.org%2Fmaven-release%2Fmaven-release-plugin%2Fexamples%2Fprepare-release.html&data=02%7C01%7Caharui%40adobe.com%7C592d812679cd41801bc708d7dc59e6b2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637220150987869588&sdata=hiTky5DHRkJUj3ikyObRoXy7tJh3re0VPOQrBM3%2B1fU%3D&reserved=0
>
>
> El jue., 9 abr. 2020 a las 8:28, <ah...@apache.org> escribió:
>
> >
> > +We are currently using maven-scm-provider-jgit with the patch for
> > [SCM-932](
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FSCM-932&data=02%7C01%7Caharui%40adobe.com%7C592d812679cd41801bc708d7dc59e6b2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637220150987869588&sdata=NvjgiTbiQG9kdKiL%2B%2FM7Z%2FRL7IZe3Cqq2yzi%2BjRLrQg%3D&reserved=0).
> We are calling
> > it version 1.13.0-SNAPSHOT
> >
> >
>
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592d812679cd41801bc708d7dc59e6b2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637220150987869588&sdata=1kOxjOx7PmOPgctQ%2FfUAPzXWYTdPeq19d3PnHm8x6jE%3D&reserved=0
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: Using SNAPSHOTS and self patched code (was Re: [royale-asjs.wiki]
branch master updated: Updated CI Server Setup (markdown))
Posted by Alex Harui <ah...@adobe.com.INVALID>.
In accordance with Maven's release philosophy, Royale code will not have any snapshot versions on the staging or release repos nor will the jars and swcs depend on snapshot versions. The CI profile will use a snapshot version of JGit unless Maven decides to release it before we get our release out. That seems to be allowed by Maven's release plugin. It only cares about the artifacts we release, not the plugins used to create the artifacts.
We need JGit in order to not store someone's credentials on a shared machine.
-Alex
On 4/9/20, 12:44 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi Alex,
using SNAPSHOTS of external software with self-patched code is something
that is not the right way to go for any project and we shouldn't allow in
Apache Royale too.
Not releasing with snapshot dependencies is something that's in Maven
official documentation [1] as something we must honor and for that reason
it's normal we don' have that our own docs.
I must say that don't understand the use of JGIT since we exposed that is
not necessary reaching step 7 without problem.
I'm not ok with using that. So please, can you remove it and use and
official way to get what you want?.
Thanks
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmaven.apache.org%2Fmaven-release%2Fmaven-release-plugin%2Fexamples%2Fprepare-release.html&data=02%7C01%7Caharui%40adobe.com%7C592d812679cd41801bc708d7dc59e6b2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637220150987869588&sdata=hiTky5DHRkJUj3ikyObRoXy7tJh3re0VPOQrBM3%2B1fU%3D&reserved=0
El jue., 9 abr. 2020 a las 8:28, <ah...@apache.org> escribió:
>
> +We are currently using maven-scm-provider-jgit with the patch for
> [SCM-932](https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FSCM-932&data=02%7C01%7Caharui%40adobe.com%7C592d812679cd41801bc708d7dc59e6b2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637220150987869588&sdata=NvjgiTbiQG9kdKiL%2B%2FM7Z%2FRL7IZe3Cqq2yzi%2BjRLrQg%3D&reserved=0). We are calling
> it version 1.13.0-SNAPSHOT
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592d812679cd41801bc708d7dc59e6b2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637220150987869588&sdata=1kOxjOx7PmOPgctQ%2FfUAPzXWYTdPeq19d3PnHm8x6jE%3D&reserved=0