[jira] [Commented] (S2GRAPH-42) Bug on EdgeTransformer with specific cases.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153909#comment-15153909 ] 

ASF GitHub Bot commented on S2GRAPH-42:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/25

    [S2GRAPH-42] Bug on EdgeTransformer with specific cases.

    + add pad to deal with different size on splitted tokens by on place holder and passed values on transform.
    
    ex) [["age_band.slot.$.8", "age_band"]] should give "age_band.slot.${age_band}.8", not losing last ".8".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-42

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit f56db4b2fb655ba9668933414ca1e238df39e1c0
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-02-19T08:35:56Z

    S2GRAPH-42 Bug on EdgeTransformer with specific cases.
    
    add pad to deal with different size on splitted tokens by on place holder and passed values on transform.
    ex) [["age_band.slot.$.8", "age_band"]] should give "age_band.slot.${age_band}.8", not losing last ".8".

----


> Bug on EdgeTransformer with specific cases.
> -------------------------------------------
>
>                 Key: S2GRAPH-42
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-42
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Minor
>              Labels: easyfix
>
> With following example, EdgeTransform gives wrong transformed result.
> {noformat}
> given: "transform": [["age_band.slot.$.8", "age_band"]]
> expected: "age_band.slot.${age_band}.8"
> result: "age_band.slot.${age_band}"
> {noformat}
> so transform logic lose ".8" 
> I think this problem comes from not comparable size on tokens split by "$" and values provided on EdgeTransformer.replace method.
> "age_band.slot.$.8" yield ["age_band.slot.", ".8"]  and values provided into replace is only ["age_band"] so zipping these two lose last element of first list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)