[jira] [Created] (STORM-3051) a Potential NPE in CgroupCenter#isSubSystemEnabled

["lujie (JIRA)" <ji...@apache.org>]

lujie created STORM-3051:
----------------------------

             Summary: a Potential NPE in CgroupCenter#isSubSystemEnabled
                 Key: STORM-3051
                 URL: https://issues.apache.org/jira/browse/STORM-3051
             Project: Apache Storm
          Issue Type: Bug
            Reporter: lujie


We have developed a static analysis tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential NPE. Our analysis shows that some callees may return null in corner case(e.g. node crash , IO exception), some of their callers have  _!=null_ check but some do not have. 

*Bug:*

callee CgroupCenter#getSubSystems return null when meet exception:
{code:java}
} catch (Exception e) {
LOG.error("Get subSystems error {}", e);
}
return null;
{code}
but its caller use it without check:
{code:java}
public boolean isSubSystemEnabled(SubSystemType subSystemType) {
  Set<SubSystem> subSystems = this.getSubSystems();
  for (SubSystem subSystem : subSystems) {
     if (subSystem.getType() == subSystemType) {
     return true;
  }
  }
  return false;
}
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)