You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/07 20:56:25 UTC
[GitHub] [incubator-nuttx] patacongo opened a new issue #484: Remove
CONFIG_FS_WRITABLE
patacongo opened a new issue #484: Remove CONFIG_FS_WRITABLE
URL: https://github.com/apache/incubator-nuttx/issues/484
This is kind of a useless configuration variable that occurs in many places and adds a lot of complexity and makes debug a lot more difficult.
It makes debug more difficult because it is not consistently set and requires a lot of debug time before you finally figure out "I needs to set CONFIG_FS_WRITABLE.
In most places affected by CONFIG_FS_WRITABLE, the configuration option is stupid: Who need read-only MMC or read-only SmartFS. Just not a useful think. And many places that do need CONFIG_FS_WRITABLE do not automatically set it. Like drivers/mtd/ftl.c. In that case, you can debug for most of the day before you finally figure out why the you can't access flash via character driver (which is a really common configuration for resource limited platforms.
It is hard to image a platform that supports a file system but has no writing enabled. I could image a system with only ROMFS or only CROMFS. But that is really about it. I am not aware of any such case, but that would be the only kind of platform that would suffer from the change.
But my opinion is that in the bigger picture, NuttX would be cleaner, less complex, and more usable with CONFIG_FS_WRITABLE removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #484: Remove
CONFIG_FS_WRITABLE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #484: Remove CONFIG_FS_WRITABLE
URL: https://github.com/apache/incubator-nuttx/issues/484#issuecomment-602145642
Fix in apps: https://github.com/apache/incubator-nuttx-apps/pull/131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #484: Remove
CONFIG_FS_WRITABLE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed issue #484: Remove CONFIG_FS_WRITABLE
URL: https://github.com/apache/incubator-nuttx/issues/484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #484: Remove
CONFIG_FS_WRITABLE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #484: Remove CONFIG_FS_WRITABLE
URL: https://github.com/apache/incubator-nuttx/issues/484#issuecomment-596177762
Agree, especially the saved code size without CONFIG_FS_WRITABLE is very smalled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services