You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ian Cook (Jira)" <ji...@apache.org> on 2021/05/12 16:52:00 UTC

[jira] [Commented] (ARROW-12756) [C++] MSVC build fails with latest gtest from vcpkg

    [ https://issues.apache.org/jira/browse/ARROW-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343360#comment-17343360 ] 

Ian Cook commented on ARROW-12756:
----------------------------------

I think we can tell vcpkg to install version 1.10.0 by adding this to {{vcpkg.json}}:
{code}
"overrides": [
        { "name": "gtest", "version": "1.10.0" }
    ]
 {code}
I believe this will cause the build to fail with C++20 because 1.10.0 doesn't include this commit: https://github.com/google/googletest/commit/61f010d
But I don't think that will affect us right now

> [C++] MSVC build fails with latest gtest from vcpkg
> ---------------------------------------------------
>
>                 Key: ARROW-12756
>                 URL: https://issues.apache.org/jira/browse/ARROW-12756
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Ian Cook
>            Assignee: Ian Cook
>            Priority: Major
>
> The gtest (GoogleTest) port on vcpkg was just upgraded from version 1.10.0 to the latest commit in the master branch of [https://github.com/google/googletest] (consistent with the "live at head" philosophy that GoogleTest follows):
> [https://github.com/microsoft/vcpkg/commit/822c2dde6a5aa452fd17f31c693b20a04304a171]
> This is causing Arrow to fail to build with Visual Studio 2019 in our {{test-build-vcpkg-win}} nightly job:
> [https://github.com/ursacomputing/crossbow/runs/2563389884#step:4:4392]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)