You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/01 03:33:46 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #8558: [Feature][e2e] project management test cases

kezhenxu94 commented on a change in pull request #8558:
URL: https://github.com/apache/dolphinscheduler/pull/8558#discussion_r816423376



##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/ProjectPage.java
##########
@@ -65,36 +69,50 @@ public ProjectPage create(String project) {
         createProjectForm().buttonSubmit().click();
 
         new WebDriverWait(driver(), 10)
-            .until(ExpectedConditions.textToBePresentInElementLocated(By.className("project-name"), project));
+                .until(ExpectedConditions.textToBePresentInElementLocated(By.className("project-name"), project));
+
+        return this;
+    }
+
+    public ProjectPage create(String project, String describe) {

Review comment:
       Project description is not that important and we don't want to cover every aspect of the ui so I think we don't need the test of creating project with description. It costs resources without bringing too many benefits. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org