You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michi Mutsuzaki (JIRA)" <ji...@apache.org> on 2014/04/01 00:01:20 UTC

[jira] [Commented] (ZOOKEEPER-1574) mismatched CR/LF endings in text files

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955778#comment-13955778 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1574:
--------------------------------------------

I'll upload the second patch after the first one gets checked in.

> mismatched CR/LF endings in text files
> --------------------------------------
>
>                 Key: ZOOKEEPER-1574
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1574
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Raja Aluri
>            Assignee: Raja Aluri
>            Priority: Minor
>             Fix For: 3.4.7, 3.5.0
>
>         Attachments: ZOOKEEPER-1574.branch-3.4.patch, ZOOKEEPER-1574.patch, ZOOKEEPER-1574.trunk.patch
>
>
> Source code in zookeeper repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> But before adding the .gitattributes file we need to normalize the existing tree, so that people when they sync after .giattributes change wont end up with a bunch of modified files in their workspace.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> [http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in]
> [http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git]
> I will submit a separate bug and patch for .gitattributes



--
This message was sent by Atlassian JIRA
(v6.2#6252)