[jira] [Commented] (HDDS-7648) Add a servername tag in UGI metrics.

["Attila Doroszlai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648658#comment-17648658 ] 

Attila Doroszlai commented on HDDS-7648:
----------------------------------------

[~xBis], I have checked UGI metrics with and without the patch.  Two observations:

# {{component}} is already available to distinguish between various servers.  Can you please clarify why it would be useful to add servername, too?
# The patch uses default port to determine the origin of metrics.  This only works with the default ports.  Using custom ports results in "unknown" servername.

Without patch:

{code}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="7b4b37c960b9", instance="ozone_datanode_3:9882", job="ozone"}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="a262df460c18", instance="ozone_datanode_1:9882", job="ozone"}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="c5ca9dc626db", instance="ozone_datanode_2:9882", job="ozone"}
ugi_metrics_login_failure_avg_time{component="om", context="ugi", hostname="dc77c67bb88c", instance="om:9874", job="ozone"}
ugi_metrics_login_failure_avg_time{component="s3g", context="ugi", hostname="06db447b7b99", instance="s3g:9878", job="ozone"}
ugi_metrics_login_failure_avg_time{component="scm", context="ugi", hostname="5d8486460d27", instance="scm:9876", job="ozone"}
{code}

With patch:

{code}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="187678e95c53", instance="ozone_datanode_1:9882", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="81776c5263cf", instance="ozone_datanode_2:9882", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="e753b86e61d8", instance="ozone_datanode_3:9882", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="om", context="ugi", hostname="35cfc44aba0b", instance="om:9874", job="ozone", servername="OM"}
ugi_metrics_login_failure_avg_time{component="s3g", context="ugi", hostname="7d376e9341d7", instance="s3g:9878", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="scm", context="ugi", hostname="65c74a28a60a", instance="scm:9876", job="ozone", servername="SCM"}
{code}

With patch, with custom ports:

{code}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="4274b582cf2e", instance="ozone_datanode_1:9882", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="d9a71a7a6877", instance="ozone_datanode_3:9882", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="datanode", context="ugi", hostname="e115421a23b5", instance="ozone_datanode_2:9882", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="om", context="ugi", hostname="9dc775f9212c", instance="om:10874", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="s3g", context="ugi", hostname="2c05a7659b7f", instance="s3g:9878", job="ozone", servername="unknown"}
ugi_metrics_login_failure_avg_time{component="scm", context="ugi", hostname="62401afc6ab6", instance="scm:10876", job="ozone", servername="unknown"}
{code}

> Add a servername tag in UGI metrics.
> ------------------------------------
>
>                 Key: HDDS-7648
>                 URL: https://issues.apache.org/jira/browse/HDDS-7648
>             Project: Apache Ozone
>          Issue Type: Improvement
>            Reporter: Christos Bisias
>            Priority: Major
>              Labels: pull-request-available
>
> The UGI metrics have no servername tag and the only way to determine if the value is referring to the SCM or OM is to match the port from the instance label.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org