You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/09/19 15:49:02 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process

lordgamez opened a new pull request, #1662:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1662

   https://issues.apache.org/jira/browse/MINIFICPP-2222
   
   -------------
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process

Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1662:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1662#discussion_r1331110112


##########
CONTRIBUTING.md:
##########
@@ -67,13 +67,13 @@ as part of the verification process, that is applied to all new contributions.
 ## Issues and Pull Requests
 
 Issues within MiNiFi C++ are tracked in the official [Apache JIRA](https://issues.apache.org/jira/projects/MINIFICPP/issues).
-New users can register freely and ask for contributor access on the
-[Developers Mailing List](https://nifi.apache.org/mailing_lists.html).
-Unassigned tickets may be assigned to yourself or filed via this JIRA instance. Pull requests can be submitted via our
-[Github Mirror](https://github.com/apache/nifi-minifi-cpp) . When doing so please create a JIRA issue for your pull
-request.
+New users can freely request JIRA access on the
+[Self-Service Portal](https://selfserve.apache.org/jira-account.html) for the nifi project. An Apache PMC member will review and
+approve the request as prudent. Unassigned tickets may be assigned to yourself or filed via this JIRA instance. As a new user looking to contribute,
+any tickets that are tagged as "beginner", "starter", or "newbie" are good places to start. Pull requests can be submitted via our
+[Github Mirror](https://github.com/apache/nifi-minifi-cpp). If your contribution does not have a corresponding JIRA issue for it then please create one.

Review Comment:
   I suppose users don't really need to be aware of this detail, updated in a956d9efe7379389441069a2d8c18b6e41872f78



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process

Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits closed pull request #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process
URL: https://github.com/apache/nifi-minifi-cpp/pull/1662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process

Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1662:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1662#discussion_r1330462212


##########
CONTRIBUTING.md:
##########
@@ -67,13 +67,13 @@ as part of the verification process, that is applied to all new contributions.
 ## Issues and Pull Requests
 
 Issues within MiNiFi C++ are tracked in the official [Apache JIRA](https://issues.apache.org/jira/projects/MINIFICPP/issues).
-New users can register freely and ask for contributor access on the
-[Developers Mailing List](https://nifi.apache.org/mailing_lists.html).
-Unassigned tickets may be assigned to yourself or filed via this JIRA instance. Pull requests can be submitted via our
-[Github Mirror](https://github.com/apache/nifi-minifi-cpp) . When doing so please create a JIRA issue for your pull
-request.
+New users can freely request JIRA access on the
+[Self-Service Portal](https://selfserve.apache.org/jira-account.html) for the nifi project. An Apache PMC member will review and
+approve the request as prudent. Unassigned tickets may be assigned to yourself or filed via this JIRA instance. As a new user looking to contribute,
+any tickets that are tagged as "beginner", "starter", or "newbie" are good places to start. Pull requests can be submitted via our
+[Github Mirror](https://github.com/apache/nifi-minifi-cpp). If your contribution does not have a corresponding JIRA issue for it then please create one.

Review Comment:
   It's a mirror of https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git (web link redirects to github, but git can interface with it)
   
   But there is two-way sync, and we're not really using the ASF GitBox interface, so this detail can be omitted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process

Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1662:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1662#discussion_r1330406048


##########
CONTRIBUTING.md:
##########
@@ -67,13 +67,13 @@ as part of the verification process, that is applied to all new contributions.
 ## Issues and Pull Requests
 
 Issues within MiNiFi C++ are tracked in the official [Apache JIRA](https://issues.apache.org/jira/projects/MINIFICPP/issues).
-New users can register freely and ask for contributor access on the
-[Developers Mailing List](https://nifi.apache.org/mailing_lists.html).
-Unassigned tickets may be assigned to yourself or filed via this JIRA instance. Pull requests can be submitted via our
-[Github Mirror](https://github.com/apache/nifi-minifi-cpp) . When doing so please create a JIRA issue for your pull
-request.
+New users can freely request JIRA access on the
+[Self-Service Portal](https://selfserve.apache.org/jira-account.html) for the nifi project. An Apache PMC member will review and
+approve the request as prudent. Unassigned tickets may be assigned to yourself or filed via this JIRA instance. As a new user looking to contribute,
+any tickets that are tagged as "beginner", "starter", or "newbie" are good places to start. Pull requests can be submitted via our
+[Github Mirror](https://github.com/apache/nifi-minifi-cpp). If your contribution does not have a corresponding JIRA issue for it then please create one.

Review Comment:
   it's not really a mirror; maybe just `... can be submitted via [GitHub](...)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process

Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1662:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1662#discussion_r1330462212


##########
CONTRIBUTING.md:
##########
@@ -67,13 +67,13 @@ as part of the verification process, that is applied to all new contributions.
 ## Issues and Pull Requests
 
 Issues within MiNiFi C++ are tracked in the official [Apache JIRA](https://issues.apache.org/jira/projects/MINIFICPP/issues).
-New users can register freely and ask for contributor access on the
-[Developers Mailing List](https://nifi.apache.org/mailing_lists.html).
-Unassigned tickets may be assigned to yourself or filed via this JIRA instance. Pull requests can be submitted via our
-[Github Mirror](https://github.com/apache/nifi-minifi-cpp) . When doing so please create a JIRA issue for your pull
-request.
+New users can freely request JIRA access on the
+[Self-Service Portal](https://selfserve.apache.org/jira-account.html) for the nifi project. An Apache PMC member will review and
+approve the request as prudent. Unassigned tickets may be assigned to yourself or filed via this JIRA instance. As a new user looking to contribute,
+any tickets that are tagged as "beginner", "starter", or "newbie" are good places to start. Pull requests can be submitted via our
+[Github Mirror](https://github.com/apache/nifi-minifi-cpp). If your contribution does not have a corresponding JIRA issue for it then please create one.

Review Comment:
   It's a mirror of https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
   
   But there is two-way sync, and we're not really using the ASF GitBox interface, so this detail can be omitted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org