You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/08/29 07:09:36 UTC
[GitHub] [airflow] eladkal opened a new pull request, #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
eladkal opened a new pull request, #33868:
URL: https://github.com/apache/airflow/pull/33868
Note: Due to the fact that there were many commits added to azure provider the between RC1 to RC2 I will not use shorten vote period. The vote will last for 72 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308384365
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -44,6 +44,7 @@ Bug Fixes
* ``Fix KubernetesPodOperator duplicating logs when interrupted (#33500)``
* ``Fix 2.7.0 db migration job errors (#33652)``
* ``Inspect container state rather than last_state when deciding whether to skip (#33702)``
+* ``Update pod.py (#33779)``
Review Comment:
I tried that once and it didn't work(?) let me try again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308363230
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -44,6 +44,7 @@ Bug Fixes
* ``Fix KubernetesPodOperator duplicating logs when interrupted (#33500)``
* ``Fix 2.7.0 db migration job errors (#33652)``
* ``Inspect container state rather than last_state when deciding whether to skip (#33702)``
+* ``Update pod.py (#33779)``
Review Comment:
@eladkal -> yes, we can update the message in CHANGELOG - we cannot update them in COMMITS. The only thing important is to make sure we leave `(#33779)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308475833
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -44,6 +44,7 @@ Bug Fixes
* ``Fix KubernetesPodOperator duplicating logs when interrupted (#33500)``
* ``Fix 2.7.0 db migration job errors (#33652)``
* ``Inspect container state rather than last_state when deciding whether to skip (#33702)``
+* ``Update pod.py (#33779)``
Review Comment:
It was probabaly in "COMMITS" :). The COMMITS list is always regenerated from scratch when the docs are generated - just to make sure it is accurate. The CHANGELOG on the other hand is only updated with new things (based on the 'PR#') and we only add new things to changelog if we see the #PR number is missing there. This allows to manually modify and move around the individual entries - hide them, reword them, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308310048
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -44,6 +44,7 @@ Bug Fixes
* ``Fix KubernetesPodOperator duplicating logs when interrupted (#33500)``
* ``Fix 2.7.0 db migration job errors (#33652)``
* ``Inspect container state rather than last_state when deciding whether to skip (#33702)``
+* ``Update pod.py (#33779)``
Review Comment:
FYI in providers we can not update commit messages in release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308473825
##########
airflow/providers/microsoft/azure/CHANGELOG.rst:
##########
@@ -36,12 +36,19 @@ Features
* ``Add AzureBatchOperator example (#33716)``
* ``feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerInstanceHook (#33467)``
* ``Add DefaultAzureCredential auth for ADX service (#33627)``
+* ``feat(providers/microsoft): add DefaultAzureCredential to data_lake (#33433)``
+* ``Allow passing fully_qualified_namespace and credential to initialize Azure Service Bus Client (#33493)``
+* ``Add DefaultAzureCredential support to cosmos (#33436)``
+* ``Add DefaultAzureCredential support to AzureBatchHook (#33469)``
Bug Fixes
~~~~~~~~~
* ``Fix updating account url for WasbHook (#33457)``
* ``Fix Azure Batch Hook instantation (#33731)``
+* ``Truncate Wasb storage account name if it's more than 24 characters (#33851)``
Review Comment:
We can combine this with line 47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #33868:
URL: https://github.com/apache/airflow/pull/33868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308475833
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -44,6 +44,7 @@ Bug Fixes
* ``Fix KubernetesPodOperator duplicating logs when interrupted (#33500)``
* ``Fix 2.7.0 db migration job errors (#33652)``
* ``Inspect container state rather than last_state when deciding whether to skip (#33702)``
+* ``Update pod.py (#33779)``
Review Comment:
It was proabaly in "COMMITS" :). The COMMITS list is always regenerated from scratch when the docs are generated - just to make sure it is accurate. The CHANGELOG on the other hand is only updated with new things (based on the 'PR#') and we only add new things to changelog if we see the #PR number is missing there. This allows to manually modify and move around the individual entries - hide them, reword them, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308481065
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -44,6 +44,7 @@ Bug Fixes
* ``Fix KubernetesPodOperator duplicating logs when interrupted (#33500)``
* ``Fix 2.7.0 db migration job errors (#33652)``
* ``Inspect container state rather than last_state when deciding whether to skip (#33702)``
+* ``Update pod.py (#33779)``
Review Comment:
Also this allows to make "iterations" of release. Whenever we "prepare docs" - like this one from the new main, only the "new" things that had not been present the last time in the CHANGELOG are added. That's why when you cancel an RC and prepare the new one, all those "new entries" land in the "commented" section stating "Please update and move the new entries that appeared since the last "prepare documantation" - that effectively allows to prepare same version several times (several RC candidates or even several times before deciding on RC). The (PR#) is the key to see if new entries should be added when you generate the docs from new main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33868: Prepare docs for Aug 2023 3rd wave of Providers (RC2)
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33868:
URL: https://github.com/apache/airflow/pull/33868#discussion_r1308554791
##########
airflow/providers/microsoft/azure/CHANGELOG.rst:
##########
@@ -36,12 +36,19 @@ Features
* ``Add AzureBatchOperator example (#33716)``
* ``feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerInstanceHook (#33467)``
* ``Add DefaultAzureCredential auth for ADX service (#33627)``
+* ``feat(providers/microsoft): add DefaultAzureCredential to data_lake (#33433)``
+* ``Allow passing fully_qualified_namespace and credential to initialize Azure Service Bus Client (#33493)``
+* ``Add DefaultAzureCredential support to cosmos (#33436)``
+* ``Add DefaultAzureCredential support to AzureBatchHook (#33469)``
Bug Fixes
~~~~~~~~~
* ``Fix updating account url for WasbHook (#33457)``
* ``Fix Azure Batch Hook instantation (#33731)``
+* ``Truncate Wasb storage account name if it's more than 24 characters (#33851)``
Review Comment:
I will try to sort it after the release. There can be several such improvements I'll handle them in bulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org