[GitHub] [arrow-rs] alamb commented on a diff in pull request #3978: Convert string_to_timestamp_nanos to doctest

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #3978:
URL: https://github.com/apache/arrow-rs/pull/3978#discussion_r1153496814


##########
arrow-cast/src/parse.rs:
##########
@@ -264,8 +264,17 @@ pub fn string_to_datetime<T: TimeZone>(
 /// This function interprets string without an explicit time zone as timestamps
 /// relative to UTC, see [`string_to_datetime`] for alternative semantics
 ///
-/// For example, both `1997-01-31 09:26:56.123Z`, `1997-01-31T09:26:56.123`,
-/// and `1997-01-31T14:26:56.123+05:00` will be parsed as the same value
+/// In particular:
+///
+/// ```
+/// # use arrow_cast::parse::string_to_timestamp_nanos;
+/// let a = string_to_timestamp_nanos("1997-01-31 09:26:56.123Z").unwrap();

Review Comment:
   ```suggestion
   /// // Note all three of thee timestamps are parsed as the same value
   /// let a = string_to_timestamp_nanos("1997-01-31 09:26:56.123Z").unwrap();
   ```



##########
arrow-cast/src/parse.rs:
##########
@@ -264,8 +264,17 @@ pub fn string_to_datetime<T: TimeZone>(
 /// This function interprets string without an explicit time zone as timestamps
 /// relative to UTC, see [`string_to_datetime`] for alternative semantics
 ///
-/// For example, both `1997-01-31 09:26:56.123Z`, `1997-01-31T09:26:56.123`,
-/// and `1997-01-31T14:26:56.123+05:00` will be parsed as the same value
+/// In particular:

Review Comment:
   ❤️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org