[GitHub] [activemq-artemis] gtully commented on a change in pull request #3580: ARTEMIS-3297 Historic Journal Backup

[GitBox <gi...@apache.org>]

gtully commented on a change in pull request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632350082



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
##########
@@ -668,6 +668,25 @@ Configuration addDiscoveryGroupConfiguration(String key,
     */
    Configuration setJournalDirectory(String dir);
 
+   String getJournalHistory();
+
+   File getJournalHistoryLocation();
+
+   /**
+    * Sets the file system directory used to store historical backup journal.
+    */
+   Configuration setJournalHistory(String dir);
+
+   int getJournalHistoryMaxDays();
+
+   Configuration  setJournalHistoryMaxDays(int days);

Review comment:
       This is a neat feature. I think I would call it something else from a configuration perspective.
   
   journalRetention or just retention
   
   configured with a:
    
   int retentionLimit > 0
   enum retentionUnit (seconds/days/numFiles)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org