[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7536: Refine mm Kconfig

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on PR #7536:
URL: https://github.com/apache/incubator-nuttx/pull/7536#issuecomment-1306140720

   > I have mixed feelings about removing some Kconfig features like that. It is good because it simplify the Kconfig, but it is bad because it is forcing the building system to compile files that most of the times are not used. @xiaoxiang781216 what are the criteria to decide which features to keep in the Kconfig and which to compile always? Maybe only the features that are mostly used should be compiled by default. Circular Buffer MM for example doesn't appear to fit in this definition.
   
   it's good candidate to remove Kconfig If the linker can remove the unused code automatically. The time saving in compile is very small. On the other hand, we need add many Kconfig in libc to skip the compile for many seldom used function. From the usage perspective, I don't see the difference between circbuf and libc/queue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org