You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by theduderog <gi...@git.apache.org> on 2016/05/27 05:59:15 UTC

[GitHub] kafka pull request: KAFKA-3761: Controller has RunningAsBroker ins...

GitHub user theduderog opened a pull request:

    https://github.com/apache/kafka/pull/1437

    KAFKA-3761: Controller has RunningAsBroker instead of RunningAsController state

    @junrao @ijuma 
    
    This works for me in local testing.  Do you see any issues?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/theduderog/kafka KAFKA-3761-broker-state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1437
    
----
commit 6278fdec8c75a6ccc610a602c8cf27c2c1706bfb
Author: Roger Hoover <ro...@gmail.com>
Date:   2016-05-27T05:54:50Z

    Setting RunningAsController after RunningAsBroker

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1437: KAFKA-3761: Remove BrokerState "RunningAsControlle...

Posted by theduderog <gi...@git.apache.org>.
GitHub user theduderog reopened a pull request:

    https://github.com/apache/kafka/pull/1437

    KAFKA-3761: Remove BrokerState "RunningAsController"

    The reasons to remove it are:
    1. It's currently broken.  The purpose of the [JIRA](https://issues.apache.org/jira/browse/KAFKA-3761) was to report that the RunningAsController state gets overwritten back to "RunningAsBroker".
    2. It's not a useful state.
      a. If clients want to use this metric to know whether a broker is ready to receive requests or not, they do not care whether or not the broker is the controller
      b. there is already a separate boolean property, KafkaController.isActive which contains this information.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/theduderog/kafka KAFKA-3761-broker-state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1437
    
----
commit c0201c5ab8125ea885ff52b234d235d288cd86fb
Author: Roger Hoover <ro...@gmail.com>
Date:   2016-06-23T21:52:32Z

    Removed RunningAsController state

commit cefead1bed0f0699908bc2819535be4a8f046fd4
Author: Roger Hoover <ro...@gmail.com>
Date:   2016-06-23T22:15:30Z

    Better formatting for ASCII art

commit 974ba7d4a27dd5ac6b43bc888ece5170737614c5
Author: Roger Hoover <ro...@gmail.com>
Date:   2016-06-24T18:26:40Z

    Added upgrade note

commit 887fbc0aca264178bb4428b1fdb98dcbe8f2ffdd
Author: Roger Hoover <ro...@gmail.com>
Date:   2016-06-24T20:18:17Z

    Updated upgrade note based on @ijuma's feedback

commit 5db6479970472fdc8366c17b1cad66971e542a48
Author: Roger Hoover <ro...@gmail.com>
Date:   2016-06-24T21:38:43Z

    Moved 0.10.1.0 section to the top

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1437: KAFKA-3761: Remove BrokerState "RunningAsControlle...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1437: KAFKA-3761: Remove BrokerState "RunningAsControlle...

Posted by theduderog <gi...@git.apache.org>.
Github user theduderog closed the pull request at:

    https://github.com/apache/kafka/pull/1437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---