[GitHub] [cassandra-sidecar] yifan-c commented on a diff in pull request #46: CASSANDRASC-50: Deprecate the sidecar cassandra health endpoint conta…

["yifan-c (via GitHub)" <gi...@apache.org>]

yifan-c commented on code in PR #46:
URL: https://github.com/apache/cassandra-sidecar/pull/46#discussion_r1220265233


##########
src/main/java/org/apache/cassandra/sidecar/cluster/InstancesConfig.java:
##########
@@ -37,14 +37,16 @@
      *
      * @param id instance's id
      * @return instance meta information
+     * @throws IllegalArgumentException when the instance with {@code id} does not exist
      */
-    InstanceMetadata instanceFromId(final int id);
+    InstanceMetadata instanceFromId(int id) throws IllegalArgumentException;

Review Comment:
   Does `NoSuchElementException` fit better?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org